Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.x: CMA: Fixing logic for CMA system call detection #4123

Merged
merged 1 commit into from
Aug 29, 2017

Conversation

kawashima-fj
Copy link
Member

The OPAL_CMA_NEED_SYSCALL_DEFS is always defined/set to 0 or 1. Therefore instead of checking if the macro is defined, we have to look at the value itself.

(cherry picked from commit d984b4b)

Refs: #4122

Though I set milestone to v2.1.2, I don't have strong opinion against deferring it to v2.1.3.

The OPAL_CMA_NEED_SYSCALL_DEFS is always defined/set to 0 or 1.  Therefore
instead of checking if the macro is defined, we have to look at the value
itself.

Signed-off-by: Pavel Shamis (Pasha) <[email protected]>
(cherry picked from commit d984b4b)
Signed-off-by: KAWASHIMA Takahiro <[email protected]>
@PHHargrove
Copy link
Member

I can confirm that cherry-picking this one commit does resolve the build failure with the 2.1.2rc2 tarball, which I reported in https://www.mail-archive.com/[email protected]/msg20340.html

@jsquyres
Copy link
Member

@hppritcha Good to go

@jsquyres jsquyres merged commit 8edd2c8 into open-mpi:v2.x Aug 29, 2017
@kawashima-fj kawashima-fj deleted the pr/v2.x/cma-macro branch August 31, 2017 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants