-
Notifications
You must be signed in to change notification settings - Fork 865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BTL TCP on macOSX broken in v4.0.x and master #5815
Comments
haven't tried 3.1.x or earlier yet. |
#5819 is what you are looking for. |
I'll give it a try tonight. I did learn that |
This might be the right time to have a clear discussion about what we want to support and what we don't. The only reason to have multiple IPs on the same interface is for load balance and QoS, 2 things that we mildly care about (there is also because "we can", but let's ignore this for now). If we drop all addresses but the one on the first device, and use multi-links we will be able to achieve the same outcome but with a selection logic greatly simplified, and a cleaner code base. I added this topic to the developer meeting agenda in few weeks. |
I've cherry-picked this to the v4.0.x branch, and verified that I can run on MACOSX with or without the if_include, with only btl self,tcp. with both hello_world and IMB. |
I confirm that this is a problem on both master and v4.0.x. It does not happen on v3.1.x. I'd argue that this is a blocker for v4.0.0. |
BTW, it's not clear yet that #5819 is the correct fix (i.e., it fixes the issue, but there's still some debate as to whether it is the correct fix or not). |
Fixed on master and v4.0.x (I also verified), and not an issue on v3.1.x. Closing this issue. Thanks to all who helped out on this one. |
As also reported by @rhc54 and @jsquyres in https://www.mail-archive.com/[email protected]//msg20758.html
The text was updated successfully, but these errors were encountered: