From ad9fae9b171da54f984275b5b9781dd4c3212501 Mon Sep 17 00:00:00 2001 From: Brian Barrett Date: Wed, 9 Feb 2022 18:04:08 +0000 Subject: [PATCH] osc/rdma: Fix double assignment typo Fix an assignment of request onto itself, which was a harmless typo, but was responsible for Coverity issues CID 1429865 and CID 1429864. Signed-off-by: Brian Barrett --- ompi/mca/osc/rdma/osc_rdma_comm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ompi/mca/osc/rdma/osc_rdma_comm.c b/ompi/mca/osc/rdma/osc_rdma_comm.c index 62f35d28d64..569cf669cae 100644 --- a/ompi/mca/osc/rdma/osc_rdma_comm.c +++ b/ompi/mca/osc/rdma/osc_rdma_comm.c @@ -398,7 +398,7 @@ static void ompi_osc_rdma_put_complete (struct mca_btl_base_module_t *btl, struc /* the lowest bit is used as a flag indicating this put operation has a request */ if ((intptr_t) context & 0x1) { - ompi_osc_rdma_request_t *request = request = (ompi_osc_rdma_request_t *) ((intptr_t) context & ~1); + ompi_osc_rdma_request_t *request = (ompi_osc_rdma_request_t *) ((intptr_t) context & ~1); sync = request->sync; if (0 == OPAL_THREAD_ADD_FETCH32 (&request->outstanding_requests, -1)) { @@ -429,7 +429,7 @@ static void ompi_osc_rdma_put_complete_flush (struct mca_btl_base_module_t *btl, /* the lowest bit is used as a flag indicating this put operation has a request */ if ((intptr_t) context & 0x1) { - ompi_osc_rdma_request_t *request = request = (ompi_osc_rdma_request_t *) ((intptr_t) context & ~1); + ompi_osc_rdma_request_t *request = (ompi_osc_rdma_request_t *) ((intptr_t) context & ~1); module = request->module; if (0 == OPAL_THREAD_ADD_FETCH32 (&request->outstanding_requests, -1)) {