Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Offset on keypoint coordinates in output #2629

Closed
2 tasks done
LjIA26 opened this issue Aug 17, 2023 · 3 comments
Closed
2 tasks done

[Bug] Offset on keypoint coordinates in output #2629

LjIA26 opened this issue Aug 17, 2023 · 3 comments
Assignees

Comments

@LjIA26
Copy link

LjIA26 commented Aug 17, 2023

Prerequisite

Bug

Thank you for your work. I found a bug.

There is an offset of the printed coordinates in the json file. We can only get the true coordinates when we set the radius of the circle that gets printed as 0. Otherwise, the printed coordinates are wrong and it prints the outer right point on the diameter of the circle that gets plotted. This should get fixed.

Reproduces the problem - code sample

Not a problem but a bug

Additional information

No response

@Ben-Louis
Copy link
Collaborator

Ben-Louis commented Aug 18, 2023

Thanks for your feedback. Could you please give an example image to illustrate this problem?

@LjIA26
Copy link
Author

LjIA26 commented Aug 18, 2023

Unfortunately, I can't share the images, but I can share the keypoints that got printed.

Because I used the keypoints from the json file on the predictions folder and then I plotted them myself on top of the images, that's how I noticed it.

with radius equal to zero:

      [
        366.69140625,
        343.91015625
      ],
      [
        349.01953125,
        252.60546875
      ],
      [
        343.12890625,
        190.75390625
      ],

with radius equal to 1:

      [
        367.69140625,
        342.91015625
      ],
      [
        350.01953125,
        251.60546875
      ],
      [
        344.12890625,
        189.75390625
      ],


@Ben-Louis
Copy link
Collaborator

Thank you for bringing this issue to our attention. This bug should have been fixed in #2631. We appreciate any additional feedback you may have on your user experience.

@LjIA26 LjIA26 closed this as completed Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants