-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Update FixedCrop for list #682
Conversation
Codecov Report
@@ Coverage Diff @@
## master #682 +/- ##
==========================================
+ Coverage 80.65% 80.69% +0.03%
==========================================
Files 199 199
Lines 11371 11383 +12
Branches 1818 1822 +4
==========================================
+ Hits 9171 9185 +14
+ Misses 1916 1915 -1
+ Partials 284 283 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. One minor comment.
mmedit/datasets/pipelines/crop.py
Outdated
@@ -183,16 +187,26 @@ def __call__(self, results): | |||
|
|||
for k in self.keys: | |||
# In fixed crop for paired images, sizes should be the same |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move line 189 to line 197.
FixedCrop will support
list
type