Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support conversion to y-channel when loading images #643

Merged
merged 3 commits into from
Dec 8, 2021

Conversation

ckkelvinchan
Copy link
Member

Motivation

As suggested by #642, support conversion to y-channel images, since some models are trained on y-channels.

Modifications

Modify mmedit/datasets/pipelines/loading.py by adding the argument convert_to in the corresponding functions.

@codecov
Copy link

codecov bot commented Dec 6, 2021

Codecov Report

Merging #643 (e22bade) into master (0ba2aae) will increase coverage by 0.07%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #643      +/-   ##
==========================================
+ Coverage   80.41%   80.49%   +0.07%     
==========================================
  Files         198      198              
  Lines       11169    11233      +64     
  Branches     1780     1795      +15     
==========================================
+ Hits         8982     9042      +60     
- Misses       1913     1915       +2     
- Partials      274      276       +2     
Flag Coverage Δ
unittests 80.47% <93.33%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmedit/datasets/pipelines/loading.py 96.01% <93.33%> (+0.75%) ⬆️
...ls/components/stylegan2/generator_discriminator.py 84.93% <0.00%> (-1.21%) ⬇️
mmedit/datasets/pipelines/random_degradations.py 93.89% <0.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ba2aae...e22bade. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants