-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Support video input and output in restoration demo #622
Conversation
Codecov Report
@@ Coverage Diff @@
## master #622 +/- ##
==========================================
- Coverage 80.69% 80.57% -0.12%
==========================================
Files 199 199
Lines 11383 11409 +26
Branches 1822 1830 +8
==========================================
+ Hits 9185 9193 +8
- Misses 1915 1932 +17
- Partials 283 284 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several lines are not covered by tests
It is tested in GPU only. Therefore it is not revealed in the CI report. |
Motivation
When inferencing a video model, one would need to convert the video (e.g.,
.mp4
) to images, and then load the images. This causes inconvenience if one wants to quickly try the result.Modification
This PR supports using video format as input and output. One could simply replace the directory with the path to the video.
Note: When saving the outputs as a video, it introduces video compression, which would lower the visual quality.