-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
priority of EvalIterHook shold be lower then IterTimerHook #473
Conversation
Hi, may I ask what command did you use when you encounter this error? |
Codecov Report
@@ Coverage Diff @@
## master #473 +/- ##
==========================================
- Coverage 80.56% 80.38% -0.19%
==========================================
Files 190 190
Lines 10338 10262 -76
Branches 1533 1533
==========================================
- Hits 8329 8249 -80
- Misses 1780 1783 +3
- Partials 229 230 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Co-authored-by: Zaida Zhou <[email protected]>
…b#473) * priority of EvalIterHook shold be lower then IterTimerHook * Update mmedit/apis/train.py Co-authored-by: Zaida Zhou <[email protected]> * Fix linting Co-authored-by: lizz <[email protected]> Co-authored-by: Zaida Zhou <[email protected]> Co-authored-by: lizz <[email protected]>
Hi @yivan-WYYGDSG !First of all, we want to express our gratitude for your significant PR in this project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR. We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/raweFPmdzG If you are Chinese or have WeChat,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:) |
Motivation
when use EvalIterHook in _non_dist_train in .mmedit/apis/train.py, it will raise keyError since the key 'data_time' is not exsist
Modification
set the priority of EvalIterHook lower then IterTimerHook