Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add config of DICGAN #394

Merged
merged 7 commits into from
Jun 29, 2021
Merged

[Feature] Add config of DICGAN #394

merged 7 commits into from
Jun 29, 2021

Conversation

Yshuo-Li
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jun 25, 2021 •
edited
Loading

Codecov Report

Merging #394 (c5546d3) into master (0fe7a10) will decrease coverage by 0.16%.
The diff coverage is n/a.

❗ Current head c5546d3 differs from pull request most recent head af89fbd. Consider uploading reports for the commit af89fbd to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #394      +/-   ##
==========================================
- Coverage   80.76%   80.59%   -0.17%     
==========================================
  Files         188      188              
  Lines       10099    10021      -78     
  Branches     1482     1482              
==========================================
- Hits         8156     8076      -80     
- Misses       1730     1731       +1     
- Partials      213      214       +1
Flag Coverage Δ
unittests 80.59% <ø> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackbones/encoder_decoders/pconv_encoder_decoder.py 43.47% <0.00%> (-2.36%) ⬇️
mmedit/models/base.py 82.75% <0.00%> (-2.09%) ⬇️
...ones/encoder_decoders/two_stage_encoder_decoder.py 53.84% <0.00%> (-1.16%) ⬇️
...dels/backbones/encoder_decoders/encoders/resnet.py 66.01% <0.00%> (-0.97%) ⬇️
...s/backbones/encoder_decoders/gl_encoder_decoder.py 81.48% <0.00%> (-0.67%) ⬇️
mmedit/datasets/pipelines/normalization.py 88.88% <0.00%> (-0.59%) ⬇️
mmedit/models/components/stylegan2/modules.py 63.92% <0.00%> (-0.49%) ⬇️
mmedit/models/mattors/indexnet.py 84.37% <0.00%> (-0.48%) ⬇️
mmedit/models/mattors/base_mattor.py 84.94% <0.00%> (-0.48%) ⬇️
mmedit/models/mattors/dim.py 82.35% <0.00%> (-0.34%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fe7a10...af89fbd. Read the comment docs.

@Yshuo-Li Yshuo-Li requested a review from ckkelvinchan June 26, 2021 03:37
@innerlee innerlee changed the base branch from dic to master June 29, 2021 08:37
innerlee
innerlee reviewed Jun 29, 2021
View reviewed changes
configs/restorers/dic/dic_gan_x8c48b6_g4_500k_CelebAHQ.py Outdated
times=60,
dataset=dict(
type=train_dataset_type,
gt_folder='data/CelebA-HQ/train_256/all_256/',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://mmediting.readthedocs.io/en/latest/inpainting_datasets.html?highlight=CelebA-HQ#celeba-hq-dataset for the folder name for this dataset

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both dic and dic-gan should be changed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, pls do

@innerlee innerlee merged commit f52c456 into open-mmlab:master Jun 29, 2021
@Yshuo-Li Yshuo-Li deleted the dcr branch June 29, 2021 09:28
Yshuo-Li added a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
@Yshuo-Li
[Feature] Add config of DICGAN (open-mmlab#394)
6120fe7 
* [Feature] Add LightCNN for DICGAN

* [Feature] Add feature loss for DICGAN

* Update DIC model for DICGAN

* [Feature] Add config of DICGAN

* Update

* Update

Co-authored-by: liyinshuo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@innerlee innerlee innerlee approved these changes

@ckkelvinchan ckkelvinchan Awaiting requested review from ckkelvinchan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yshuo-Li @innerlee