Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DIC model for DICGAN #393

Merged
merged 8 commits into from
Jun 29, 2021
Merged

Update DIC model for DICGAN #393

merged 8 commits into from
Jun 29, 2021

Conversation

Yshuo-Li
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #393 (eb75c7c) into master (b307688) will decrease coverage by 0.04%.
The diff coverage is 79.16%.

❗ Current head eb75c7c differs from pull request most recent head d6d8f03. Consider uploading reports for the commit d6d8f03 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #393      +/-   ##
==========================================
- Coverage   80.80%   80.76%   -0.05%     
==========================================
  Files         188      188              
  Lines       10056    10099      +43     
  Branches     1473     1482       +9     
==========================================
+ Hits         8126     8156      +30     
- Misses       1725     1730       +5     
- Partials      205      213       +8     
Flag Coverage Δ
unittests 80.75% <79.16%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmedit/models/restorers/dic.py 68.14% <79.16%> (+5.28%) ⬆️
...ls/components/stylegan2/generator_discriminator.py 84.93% <0.00%> (-1.21%) ⬇️
mmedit/models/backbones/sr_backbones/dic_net.py 98.20% <0.00%> (-0.60%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b307688...d6d8f03. Read the comment docs.

liyinshuo added 2 commits June 25, 2021 17:42
@Yshuo-Li Yshuo-Li requested a review from ckkelvinchan June 26, 2021 03:36
@innerlee innerlee changed the base branch from lf to master June 29, 2021 03:44
@innerlee
Copy link
Contributor

Linting failed

@innerlee innerlee merged commit 0fe7a10 into open-mmlab:master Jun 29, 2021
@Yshuo-Li Yshuo-Li deleted the dic branch June 29, 2021 08:39
Yshuo-Li added a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
* [Feature] Add LightCNN for DICGAN

* [Feature] Add feature loss for DICGAN

* Update DIC model for DICGAN

* Update

* Update

* Fix

* Update

Co-authored-by: liyinshuo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants