[Feature] Add Transferal Perceptual Loss #372
Conversation
Codecov Report
@@ Coverage Diff @@
## master #372 +/- ##
==========================================
+ Coverage 80.43% 80.50% +0.06%
==========================================
Files 186 186
Lines 9911 9936 +25
Branches 1444 1450 +6
==========================================
+ Hits 7972 7999 +27
+ Misses 1745 1744 -1
+ Partials 194 193 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
|
||
|
|
||
| @LOSSES.register_module() | ||
| class TPerceptualLoss(nn.Module): |
There was a problem hiding this comment.
A single T is hard to guess. Use the full name is ok
|
|
||
| Args: | ||
| loss_weight (float): Loss weight. Default: 1.0. | ||
| use_s (bool): If True, use soft-attention tensor in TPerceptualLoss. | ||
| Default: True. | ||
| use_s (bool): If True, use soft-attention tensor. Default: True. |
There was a problem hiding this comment.
Same here. s is very cryptic.
|
On names. They should be accessible both for beginners who don't know what they are and for experts who knows a lot similar concepts. It is not for the author him/herself who knows exactly what a letter "s" or "T" stands for. |
|
|
||
|
|
||
| @LOSSES.register_module() | ||
| class TransferalPerceptualLoss(nn.Module): |
There was a problem hiding this comment.
Double check Texture vs Transferal. If the latter, pls modify the pr title accordingly
Yshuo-Li
changed the title
* [Feature] Add Texture Perceptual Loss * Rename * Rename Co-authored-by: liyinshuo <[email protected]>
No description provided.