Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add DIC #363

Merged
merged 5 commits into from
Jun 15, 2021
Merged

[Feature] Add DIC #363

merged 5 commits into from
Jun 15, 2021

Conversation

Yshuo-Li
Copy link
Collaborator

@Yshuo-Li Yshuo-Li commented Jun 8, 2021

No description provided.

@codecov
Copy link

codecov bot commented Jun 8, 2021 •
edited
Loading

Codecov Report

Merging #363 (b091666) into master (e1b544e) will decrease coverage by 0.05%.
The diff coverage is 63.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #363      +/-   ##
==========================================
- Coverage   80.38%   80.32%   -0.06%     
==========================================
  Files         182      184       +2     
  Lines        9733     9831      +98     
  Branches     1413     1427      +14     
==========================================
+ Hits         7824     7897      +73     
- Misses       1717     1742      +25     
  Partials      192      192
Flag Coverage Δ
unittests 80.30% <63.38%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmedit/models/restorers/dic.py 62.85% <62.85%> (ø)
mmedit/models/restorers/__init__.py 100.00% <100.00%> (ø)
mmedit/datasets/__init__.py 100.00% <0.00%> (ø)
mmedit/datasets/sr_test_multiple_gt_dataset.py 100.00% <0.00%> (ø)
mmedit/datasets/sr_folder_multiple_gt_dataset.py 100.00% <0.00%> (ø)
mmedit/models/backbones/sr_backbones/dic_net.py 98.80% <0.00%> (+0.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1b544e...b091666. Read the comment docs.

@innerlee innerlee requested a review from ckkelvinchan June 8, 2021 05:33
ckkelvinchan
ckkelvinchan reviewed Jun 12, 2021
View reviewed changes
mmedit/models/restorers/dic.py Show resolved Hide resolved
mmedit/models/restorers/dic.py Outdated Show resolved Hide resolved
tests/test_dic_model.py Outdated Show resolved Hide resolved
mmedit/models/restorers/dic.py Outdated Show resolved Hide resolved
mmedit/models/restorers/dic.py Show resolved Hide resolved
ckkelvinchan
ckkelvinchan reviewed Jun 12, 2021
View reviewed changes
Copy link
Member

@ckkelvinchan ckkelvinchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment about the_path. And there are many lines not covered by unittest.

mmedit/models/restorers/dic.py Outdated Show resolved Hide resolved
innerlee
innerlee reviewed Jun 15, 2021
View reviewed changes
mmedit/models/restorers/dic.py

# model
self.generator = build_backbone(generator)
self.img_denormalize = ImgNormalize(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is it used?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, where is the normalize corresponds to this denormalize?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The normalize is in pipeline (called in the config file, similar to other method of this repo).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about the first question

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: Where is it used?
A: Deleted by mistake in the previous version (f0b85d2).

This problem has been fixed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this de-normalization be configurable? Just asking... We can leave the better normalize-denormalize story to future work. Currently they are quite ad-hoc.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

post-pipeline?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe...

innerlee
innerlee reviewed Jun 15, 2021
View reviewed changes
tests/test_dic_model.py Outdated Show resolved Hide resolved
@innerlee innerlee merged commit e52dc1a into open-mmlab:master Jun 15, 2021
@Yshuo-Li Yshuo-Li deleted the dic branch June 19, 2021 03:02
Yshuo-Li added a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
@Yshuo-Li
[Feature] Add DIC (open-mmlab#363)
6c5cb6a 
* [Feature] Add DIC

* Add test

* Fix

* Fix

* Update

Co-authored-by: liyinshuo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@innerlee innerlee innerlee approved these changes

@ckkelvinchan ckkelvinchan ckkelvinchan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yshuo-Li @ckkelvinchan @innerlee