Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhance] Add custom_hooks #362

Merged
merged 1 commit into from
Jun 8, 2021
Merged

[enhance] Add custom_hooks #362

merged 1 commit into from
Jun 8, 2021

Conversation

Yshuo-Li
Copy link
Collaborator

@Yshuo-Li Yshuo-Li commented Jun 8, 2021

No description provided.

@Yshuo-Li Yshuo-Li mentioned this pull request Jun 8, 2021
@innerlee
Copy link
Contributor

innerlee commented Jun 8, 2021

Does this affect testing?

@codecov
Copy link

codecov bot commented Jun 8, 2021

Codecov Report

Merging #362 (eece0f1) into master (7622cf8) will decrease coverage by 0.14%.
The diff coverage is 5.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #362      +/-   ##
==========================================
- Coverage   80.11%   79.96%   -0.15%     
==========================================
  Files         181      181              
  Lines        9496     9515      +19     
  Branches     1385     1389       +4     
==========================================
+ Hits         7608     7609       +1     
- Misses       1698     1716      +18     
  Partials      190      190              
Flag Coverage Δ
unittests 79.94% <5.26%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmedit/apis/train.py 18.00% <5.26%> (-2.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7622cf8...eece0f1. Read the comment docs.

@Yshuo-Li
Copy link
Collaborator Author

Yshuo-Li commented Jun 8, 2021

Does this affect testing?

It doesn't affect testing.

@innerlee innerlee merged commit 6f69321 into open-mmlab:master Jun 8, 2021
@Yshuo-Li Yshuo-Li deleted the hook branch June 9, 2021 01:52
Yshuo-Li added a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
@yumath
Copy link

yumath commented Nov 18, 2022

parameters which created in my custom hook can not be updated by grad

@yumath
Copy link

yumath commented Nov 18, 2022

parameters which created in my custom hook can not be updated by grad

I replaced the modules in runner.model

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants