[Feature] Add FeedbackBlock #345
Conversation
Codecov Report
@@ Coverage Diff @@
## master #345 +/- ##
==========================================
+ Coverage 80.01% 80.10% +0.09%
==========================================
Files 181 182 +1
Lines 9536 9581 +45
Branches 1391 1397 +6
==========================================
+ Hits 7630 7675 +45
Misses 1716 1716
Partials 190 190
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| mid_channels, | ||
| kernel_size=1), nn.PReLU(init=prelu_init))) | ||
|
|
||
| self.last = nn.Sequential( |
|
There are some other locations using |
| super().__init__() | ||
|
|
||
| stride = upscale_factor | ||
| padding = 2 |
There was a problem hiding this comment.
Move L26 and L28 to __init__'s arguments.
| """Reset 'self.need_reset' to 'True'. | ||
| """ | ||
|
|
||
| self.need_reset = True |
There was a problem hiding this comment.
Could you please explain briefly about this reset mechanism? What is it used for
There was a problem hiding this comment.
The control function of the feedback channels.
I have checked the repo and found that it was not used now, so I will delete this function.
There was a problem hiding this comment.
if need reset, the feedback data (last_hidden) will be replaced by x
|
echos kelvin. Please rename ".first" and ".last" to other names. This has happend multiple times. They are not good names. |
* [Feature] Add FeedbackBlock * Update * Update * Fix Co-authored-by: liyinshuo <[email protected]>
For DIC