Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PSNR when input is uint8 #294

Merged
merged 1 commit into from
May 7, 2021
Merged

Fix PSNR when input is uint8 #294

merged 1 commit into from
May 7, 2021

Conversation

Yshuo-Li
Copy link
Collaborator

@Yshuo-Li Yshuo-Li commented May 7, 2021

Fix #288

@Yshuo-Li Yshuo-Li requested a review from innerlee May 7, 2021 12:11
@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #294 (075ee60) into master (3cfdd8f) will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #294   +/-   ##
=======================================
  Coverage   80.54%   80.54%           
=======================================
  Files         162      162           
  Lines        8091     8091           
  Branches     1192     1192           
=======================================
  Hits         6517     6517           
  Misses       1429     1429           
  Partials      145      145           
Flag Coverage Δ
unittests 80.54% <66.66%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmedit/core/evaluation/metrics.py 94.88% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cfdd8f...075ee60. Read the comment docs.

@innerlee innerlee changed the title Tiny fix of PSNR Fix of PSNR when input is uint8 May 7, 2021
@innerlee innerlee changed the title Fix of PSNR when input is uint8 Fix PSNR when input is uint8 May 7, 2021
@innerlee innerlee merged commit 41968e2 into open-mmlab:master May 7, 2021
@Yshuo-Li Yshuo-Li deleted the psnr branch May 8, 2021 02:02
Yshuo-Li added a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
Co-authored-by: liyinshuo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overflow in PSNR computation
2 participants