add sr_folder_ref_dataset #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #292 +/- ##
==========================================
+ Coverage 80.93% 80.97% +0.03%
==========================================
Files 164 165 +1
Lines 8228 8266 +38
Branches 1194 1200 +6
==========================================
+ Hits 6659 6693 +34
Misses 1425 1425
- Partials 144 148 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
added 3 commits
May 17, 2021 21:40
| @@ -72,6 +73,7 @@ def __init__(self, | |||
| filename_tmp_gt='{}', | |||
| filename_tmp_lq='{}'): | |||
| super().__init__(pipeline, scale, test_mode) | |||
| assert gt_folder or lq_folder | |||
There was a problem hiding this comment.
Better add a message here (e.g. At least one of 'gt_folder and 'lq_folder' cannot be None.). Looks good to me other than this.
ckkelvinchan
approved these changes
May 17, 2021
innerlee
reviewed
May 21, 2021
innerlee
approved these changes
May 21, 2021
Yshuo-Li
added a commit
to Yshuo-Li/mmediting
that referenced
this pull request
Jul 15, 2022
* add sr_folder_ref_dataset * add test * Fix * Fix * Fix * Rename Co-authored-by: liyinshuo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For TTSR