Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liif config #234

Merged
merged 5 commits into from
Apr 7, 2021
Merged

Liif config #234

merged 5 commits into from
Apr 7, 2021

Conversation

Yshuo-Li
Copy link
Collaborator

@Yshuo-Li Yshuo-Li commented Apr 5, 2021

Add config file of LIIF.

@Yshuo-Li Yshuo-Li requested review from hejm37 and innerlee and removed request for hejm37 April 5, 2021 14:59
@codecov
Copy link

codecov bot commented Apr 5, 2021

Codecov Report

Merging #234 (e723fe1) into master (3a04b6e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #234   +/-   ##
=======================================
  Coverage   81.41%   81.41%           
=======================================
  Files         153      153           
  Lines        7413     7413           
  Branches     1088     1088           
=======================================
  Hits         6035     6035           
  Misses       1247     1247           
  Partials      131      131           
Flag Coverage Δ
unittests 81.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a04b6e...e723fe1. Read the comment docs.

@Yshuo-Li Yshuo-Li removed the request for review from innerlee April 5, 2021 15:10
@innerlee
Copy link
Contributor

innerlee commented Apr 6, 2021

Need rebase now

type='LoadImageFromFile',
io_backend='disk',
key='gt',
flag='unchanged',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What the reason to use unchanged?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

color is ok, too. Will be modified to color.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are different, so its better to be clear and exact

@@ -0,0 +1,168 @@
exp_name = 'liif_edsr_norm_x2~4_c64b16_g1_1000k_div2k'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

avoid ~ in filename

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- is ok

local_ensemble=True,
feat_unfold=True,
cell_decode=True,
data_mean=[0.4488, 0.4371, 0.4040],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rgb_mean

dict(type='RandomDownSampling', scale_min=scale_max, scale_max=scale_max),
dict(type='RescaleToZeroOne', keys=['lq', 'gt']),
dict(
type='Normalize',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be removed?

@innerlee innerlee merged commit 432b5be into open-mmlab:master Apr 7, 2021
@Yshuo-Li Yshuo-Li deleted the liif_config branch April 8, 2021 08:16
Yshuo-Li added a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
* Add config of LIIF.

* Rebase and modify pipeline.

* Add download links.

* Move link position.

* Modify README.md

Co-authored-by: liyinshuo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants