Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SRFolderDatasetGT. #223

Merged
merged 2 commits into from
Mar 25, 2021
Merged

Conversation

Yshuo-Li
Copy link
Collaborator

Add SRFolderDatasetGT, only read GT image from folder.
And LQ image will be generated by DownSampling (in another PR).

@codecov
Copy link

codecov bot commented Mar 14, 2021

Codecov Report

Merging #223 (de4f182) into master (79f74a1) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #223      +/-   ##
==========================================
+ Coverage   81.71%   81.73%   +0.02%     
==========================================
  Files         148      150       +2     
  Lines        7055     7118      +63     
  Branches     1047     1054       +7     
==========================================
+ Hits         5765     5818      +53     
- Misses       1171     1179       +8     
- Partials      119      121       +2     
Flag Coverage Δ
unittests 81.73% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmedit/datasets/__init__.py 100.00% <100.00%> (ø)
mmedit/datasets/sr_folder_gt_dataset.py 100.00% <100.00%> (ø)
mmedit/models/common/generation_model_utils.py 95.19% <0.00%> (-4.81%) ⬇️
mmedit/datasets/pipelines/__init__.py 100.00% <0.00%> (ø)
mmedit/datasets/pipelines/down_sampling.py 89.13% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79f74a1...de4f182. Read the comment docs.

@Yshuo-Li Yshuo-Li requested a review from innerlee March 22, 2021 08:30
@innerlee
Copy link
Contributor

Thanks! Since our datasets have Dataset as suffix, the SRFolderDatasetGT class could be renamed to SRGTFolderDataset or SRFolderGTDataset or SRGroundTruthFolderDataset.

@innerlee innerlee merged commit 6ca455f into open-mmlab:master Mar 25, 2021
@Yshuo-Li Yshuo-Li deleted the sr_folder_dataset_gt branch April 8, 2021 08:18
Yshuo-Li added a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
Co-authored-by: 李尹硕 <SENSETIME\[email protected]>
Co-authored-by: liyinshuo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants