Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Genarate traininglist.json for extendedfg. #200

Merged
merged 3 commits into from
Feb 18, 2021

Conversation

yaochaorui
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Feb 18, 2021

Codecov Report

Merging #200 (2250432) into master (a9fd839) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #200   +/-   ##
=======================================
  Coverage   82.19%   82.19%           
=======================================
  Files         145      145           
  Lines        6700     6700           
  Branches      997      997           
=======================================
  Hits         5507     5507           
  Misses       1090     1090           
  Partials      103      103           
Flag Coverage Δ
unittests 82.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9fd839...2e1824e. Read the comment docs.

@@ -112,16 +115,14 @@ def main():
os.makedirs(p, exist_ok=True)

fg_names = osp.join(dir_prefix, f'{fname_prefix}_fg_names.txt')
save_json_path = f'{fname_prefix}_list.json'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this override the DIM filelist?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the filename to f'{fname_prefix}_list_fba.json'

@innerlee innerlee merged commit 91810f3 into open-mmlab:master Feb 18, 2021
@innerlee
Copy link
Contributor

Oh the file structure should be modified accordingly

Yshuo-Li pushed a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
Genarate traininglist.json for extendedfg.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants