Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] fix dtype of pytorch2onnx #1629

Merged
merged 2 commits into from
Feb 10, 2023
Merged

Conversation

Z-Fran
Copy link
Collaborator

@Z-Fran Z-Fran commented Feb 7, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Fix the error RuntimeError: "upsample_bicubic2d" not implemented for 'Byte'

Modification

Please briefly describe what modification is made in this PR.

Who can help? @ them here!

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@Z-Fran Z-Fran requested a review from zengyh1900 February 7, 2023 06:26
@Z-Fran Z-Fran self-assigned this Feb 7, 2023
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Base: 88.98% // Head: 88.98% // No change to project coverage 👍

Coverage data is based on head (205f6ff) compared to base (e7f9c3e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           dev-1.x    #1629   +/-   ##
========================================
  Coverage    88.98%   88.98%           
========================================
  Files          400      400           
  Lines        26072    26072           
  Branches      4043     4043           
========================================
  Hits         23199    23199           
  Misses        1974     1974           
  Partials       899      899           
Flag Coverage Δ
unittests 88.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Z-Fran Z-Fran merged commit 78126da into open-mmlab:dev-1.x Feb 10, 2023
@Z-Fran Z-Fran mentioned this pull request Mar 2, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants