Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Refactor fileio #1572

Merged
merged 15 commits into from
Jan 16, 2023
Merged

[Refactor] Refactor fileio #1572

merged 15 commits into from
Jan 16, 2023

Conversation

Z-Fran
Copy link
Collaborator

@Z-Fran Z-Fran commented Jan 3, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Use the new fileio from mmengine
open-mmlab/mmengine#533

Modification

  1. modify FileClient to get_file_backend in mmedit/datasets
  2. modify FileClient to get_file_backend in mmedit/datasets/transforms
  3. modify FileClient to get_file_backend in mmedit/apis
  4. modify FileClient to get_file_backend in mmedit/visualization

Who can help? @ them here!

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@Z-Fran Z-Fran added the kind/enhancement refactoring, improving CI, template, etc. label Jan 3, 2023
@Z-Fran Z-Fran self-assigned this Jan 3, 2023
@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Base: 87.90% // Head: 87.91% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (bc68db6) compared to base (e7c0539).
Patch coverage: 96.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #1572      +/-   ##
===========================================
+ Coverage    87.90%   87.91%   +0.01%     
===========================================
  Files          399      399              
  Lines        26015    26024       +9     
  Branches      4044     4048       +4     
===========================================
+ Hits         22868    22879      +11     
  Misses        2240     2240              
+ Partials       907      905       -2     
Flag Coverage Δ
unittests 87.91% <96.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmedit/datasets/data_utils.py 36.47% <71.42%> (ø)
mmedit/visualization/vis_backend.py 92.26% <92.85%> (-0.29%) ⬇️
mmedit/datasets/transforms/loading.py 93.06% <95.23%> (+0.06%) ⬆️
mmedit/apis/inferencers/inference_functions.py 77.56% <100.00%> (ø)
mmedit/datasets/basic_conditional_dataset.py 94.44% <100.00%> (ø)
mmedit/datasets/basic_frames_dataset.py 97.43% <100.00%> (+0.04%) ⬆️
mmedit/datasets/basic_image_dataset.py 97.05% <100.00%> (+0.08%) ⬆️
mmedit/datasets/cifar10_dataset.py 100.00% <100.00%> (ø)
mmedit/datasets/grow_scale_image_dataset.py 98.59% <100.00%> (+1.40%) ⬆️
mmedit/datasets/mscoco_dataset.py 91.42% <100.00%> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Z-Fran Z-Fran requested review from LeoXing1996 and plyfager January 5, 2023 07:33
Copy link
Collaborator

@plyfager plyfager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may check all related configs have been modified.

@Z-Fran Z-Fran merged commit ad24a5a into open-mmlab:dev-1.x Jan 16, 2023
liangzelong pushed a commit to liangzelong/mmediting that referenced this pull request Jan 16, 2023
* [Refactor] Refactor fileio

* fix ut

* fix self.backend_args

* fix self.backend_args

* fix self.backend_args

* fix self.backend_args

* fix vis_backend

* fix vis_backend

* fix vis_backend

* fix vis_backend

* fix vis_backend

* fix ut
@Z-Fran Z-Fran mentioned this pull request Mar 2, 2023
7 tasks
@Z-Fran Z-Fran linked an issue Mar 15, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement refactoring, improving CI, template, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Refactoring File IO
2 participants