Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MirrorExtend for training BasicVSR and IconVSR #253

Merged
merged 3 commits into from
Apr 14, 2021
Merged

Add MirrorExtend for training BasicVSR and IconVSR #253

merged 3 commits into from
Apr 14, 2021

Conversation

ckkelvinchan
Copy link
Member

BasicVSR and IconVSR extend the 7-frame Vimeo-90K sequences to 14 frames by mirroring them. This PR adds support to this operation by adding MirrorExtend.

@ckkelvinchan ckkelvinchan changed the title Add configuration files of BasicVSR Add MirrorExtend for training BasicVSR and IconVSR Apr 13, 2021
@codecov
Copy link

codecov bot commented Apr 13, 2021 •
edited
Loading

Codecov Report

Merging #253 (d5a6a2a) into master (eea1f66) will decrease coverage by 0.08%.
The diff coverage is 35.71%.

❗ Current head d5a6a2a differs from pull request most recent head 4421f51. Consider uploading reports for the commit 4421f51 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #253      +/-   ##
==========================================
- Coverage   81.36%   81.28%   -0.09%     
==========================================
  Files         158      158              
  Lines        7733     7747      +14     
  Branches     1145     1148       +3     
==========================================
+ Hits         6292     6297       +5     
- Misses       1297     1306       +9     
  Partials      144      144
Flag Coverage Δ
unittests 81.28% <35.71%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmedit/datasets/pipelines/__init__.py 100.00% <ø> (ø)
mmedit/datasets/pipelines/augmentation.py 96.79% <35.71%> (-2.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eea1f66...4421f51. Read the comment docs.

innerlee
innerlee reviewed Apr 13, 2021
View reviewed changes
mmedit/datasets/pipelines/augmentation.py Outdated


@PIPELINES.register_module()
class MirrorExtend:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about MirrorSequenceExtend, so that to rule out the wrong guess of spatial extention.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, will change~

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another idea: MirrorSequence

Copy link
Member Author

@ckkelvinchan ckkelvinchan Apr 13, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one seems more succinct. Will change. Thanks~

@innerlee innerlee merged commit 32b55a4 into open-mmlab:master Apr 14, 2021
@ckkelvinchan ckkelvinchan deleted the mirror_extend branch April 14, 2021 10:41
Yshuo-Li pushed a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
@ckkelvinchan
Add MirrorExtend for training BasicVSR and IconVSR (open-mmlab#253)
30522aa 
* Add MirrorExtend

* rename to MirrorSequenceExtend

* rename to 'MirrorSequence'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@innerlee innerlee innerlee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ckkelvinchan @innerlee