Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] fix model_zoo script #1666

Merged
merged 3 commits into from
Mar 2, 2023
Merged

Conversation

Z-Fran
Copy link
Collaborator

@Z-Fran Z-Fran commented Feb 24, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

Who can help? @ them here!

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@Z-Fran Z-Fran requested a review from zengyh1900 February 24, 2023 05:16
@Z-Fran Z-Fran self-assigned this Feb 24, 2023
Copy link
Collaborator

@zengyh1900 zengyh1900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. please also update https://github.com/open-mmlab/mmediting/blob/674011f02692db05002ec990d913fa9979853bae/docs/en/.dev_scripts/update_model_zoo.py#L98 and https://github.com/open-mmlab/mmediting/blob/674011f02692db05002ec990d913fa9979853bae/docs/en/.dev_scripts/update_model_zoo.py#L93
  2. We can add the .dev_script/update_model_zoo.py to pre-commit. Since this script is necessary for building the documentation page for model zoo, which can also used to ensure the quality of readme.

@Z-Fran Z-Fran requested a review from zengyh1900 March 2, 2023 04:02
Conflicts:
	configs/guided_diffusion/adm-u_8xb32_imagenet-512x512.py
@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.01 ⚠️

Comparison is base (2b1bbdc) 87.80% compared to head (a5a1989) 87.80%.

❗ Current head a5a1989 differs from pull request most recent head 8ac8e16. Consider uploading reports for the commit 8ac8e16 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #1666      +/-   ##
===========================================
- Coverage    87.80%   87.80%   -0.01%     
===========================================
  Files          399      399              
  Lines        26368    26372       +4     
  Branches      4114     4114              
===========================================
+ Hits         23152    23155       +3     
- Misses        2329     2330       +1     
  Partials       887      887              
Flag Coverage Δ
unittests 87.80% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...odels/data_preprocessors/edit_data_preprocessor.py 98.00% <ø> (ø)
...els/editors/inst_colorization/inst_colorization.py 38.46% <0.00%> (ø)
mmedit/apis/inferencers/inference_functions.py 77.48% <50.00%> (-0.14%) ⬇️
mmedit/apis/inferencers/colorization_inferencer.py 77.50% <100.00%> (+1.18%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zengyh1900 zengyh1900 merged commit 889711a into open-mmlab:dev-1.x Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants