Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] fix model index #1559

Merged
merged 3 commits into from
Dec 28, 2022
Merged

[Fix] fix model index #1559

merged 3 commits into from
Dec 28, 2022

Conversation

zengyh1900
Copy link
Collaborator

@zengyh1900 zengyh1900 commented Dec 28, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

  1. correct metafile and model index, so that the part of model zoo in documentation can be aligned with model-index.

Modification

  • update .dev_scripts/update_model_index.py
  • update configs/guided_diffusion/README.md
  • update configs/basicvsr_pp/README.md
  • delete configs without results in biggan, styleganv2
  • add the skip label to dim, cyclegan, ggan, pix2pix to avoid warning when updating model_index.

Who can help? @ them here!

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

.dev_scripts/README.md Outdated Show resolved Hide resolved
@zengyh1900 zengyh1900 changed the title Fix model zoo [Fix] fix model index Dec 28, 2022
@zengyh1900 zengyh1900 merged commit ea006b1 into open-mmlab:dev-1.x Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants