Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Refactor metric and loop #1540

Merged
merged 18 commits into from
Feb 21, 2023
Merged

[Enhancement] Refactor metric and loop #1540

merged 18 commits into from
Feb 21, 2023

Conversation

LeoXing1996
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Unify MultiLoop and GenLoop in one Loop.

Modification

Support EditLoops.

NOTE

This PR depends on #1537.

Who can help? @ them here!

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@LeoXing1996 LeoXing1996 added the kind/enhancement refactoring, improving CI, template, etc. label Dec 16, 2022
@LeoXing1996 LeoXing1996 self-assigned this Dec 16, 2022
@LeoXing1996 LeoXing1996 force-pushed the refactor-metric-loop-and-preprocessor branch 2 times, most recently from ae4965c to b2fc76d Compare January 13, 2023 03:04
@LeoXing1996 LeoXing1996 force-pushed the refactor-metric-loop-and-preprocessor branch from a071059 to b219a43 Compare February 7, 2023 07:50
@LeoXing1996 LeoXing1996 force-pushed the leoxing/refactor-metric-and-loop branch from 426d526 to b3097dd Compare February 8, 2023 09:40
@codecov
Copy link

codecov bot commented Feb 13, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (refactor-metric-loop-and-preprocessor@d2177f3). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 7ff6946 differs from pull request most recent head 970f85f. Consider uploading reports for the commit 970f85f to get more accurate results

Additional details and impacted files 
@@                           Coverage Diff                            @@
##             refactor-metric-loop-and-preprocessor    #1540   +/-   ##
========================================================================
  Coverage                                         ?   88.97%           
========================================================================
  Files                                            ?      398           
  Lines                                            ?    25956           
  Branches                                         ?     4080           
========================================================================
  Hits                                             ?    23095           
  Misses                                           ?     1996           
  Partials                                         ?      865
Flag Coverage Δ
unittests 88.97% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Z-Fran Z-Fran self-requested a review February 15, 2023 10:55
Z-Fran
Z-Fran reviewed Feb 15, 2023
View reviewed changes
mmedit/engine/hooks/visualization_hook.py Outdated Show resolved Hide resolved
mmedit/engine/optimizers/pggan_optimizer_constructor.py Outdated Show resolved Hide resolved
mmedit/evaluation/metrics/fid.py Outdated Show resolved Hide resolved
configs/_base_/default_runtime.py Outdated Show resolved Hide resolved
configs/_base_/default_runtime.py Outdated Show resolved Hide resolved
@LeoXing1996 LeoXing1996 force-pushed the leoxing/refactor-metric-and-loop branch from b58d682 to f858696 Compare February 17, 2023 03:55
@LeoXing1996 LeoXing1996 force-pushed the refactor-metric-loop-and-preprocessor branch from 1867732 to d2177f3 Compare February 18, 2023 07:07
zengyh1900
zengyh1900 requested changes Feb 21, 2023
View reviewed changes
Copy link
Collaborator

@zengyh1900 zengyh1900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loops need to be reconsidered.

@LeoXing1996 LeoXing1996 force-pushed the leoxing/refactor-metric-and-loop branch from ac11791 to 970f85f Compare February 21, 2023 09:32
@LeoXing1996 LeoXing1996 merged commit 490a4e2 into open-mmlab:refactor-metric-loop-and-preprocessor Feb 21, 2023
@LeoXing1996 LeoXing1996 deleted the leoxing/refactor-metric-and-loop branch February 21, 2023 11:20
@LeoXing1996 LeoXing1996 mentioned this pull request Feb 21, 2023
Merged
7 tasks
LeoXing1996 added a commit that referenced this pull request Feb 21, 2023
@LeoXing1996
[Enhancement] Refactor metric and loop (#1540)
be5f5f7 
* support new loops

* refactor base sample wise metrics, FID and IS

* adopt configs to new loops

* refine EditLoops and add docstring and unit test for EditLoops

* rename GenEvaluator to EditEvaluator

* revise configs for new EditLoops and EditEvaluator

* remove unused imported modules

* revise unit test of BaseSampleWiseMetric

* remove GenDataPreprocessor, GenLoop from configs, docstrings and tutorials

* avoid raise duplicate conversion warning in EditDataprocessor

* revise channel order conversion in FID metric

* rename GenLogProcessor and GenIterTimeHook to EditLogProcessor and EditIterTimeHook

* rename some elements in default_runtime

* support non-scalar in get_log_after_epoch as MMEngine's LogProcessor

* save metainfo in Resize for outkeys

* complete prepare method for Matting metrics

* remove GenLoop, MutliLoop, GenDataPreprocessor

* remove PixelData
LeoXing1996 added a commit that referenced this pull request Feb 23, 2023
@LeoXing1996
[Enhancement] Refactor metric and loop (#1540)
5e00ed7 
* support new loops

* refactor base sample wise metrics, FID and IS

* adopt configs to new loops

* refine EditLoops and add docstring and unit test for EditLoops

* rename GenEvaluator to EditEvaluator

* revise configs for new EditLoops and EditEvaluator

* remove unused imported modules

* revise unit test of BaseSampleWiseMetric

* remove GenDataPreprocessor, GenLoop from configs, docstrings and tutorials

* avoid raise duplicate conversion warning in EditDataprocessor

* revise channel order conversion in FID metric

* rename GenLogProcessor and GenIterTimeHook to EditLogProcessor and EditIterTimeHook

* rename some elements in default_runtime

* support non-scalar in get_log_after_epoch as MMEngine's LogProcessor

* save metainfo in Resize for outkeys

* complete prepare method for Matting metrics

* remove GenLoop, MutliLoop, GenDataPreprocessor

* remove PixelData
LeoXing1996 added a commit that referenced this pull request Feb 28, 2023
@LeoXing1996
[Enhancement] Refactor metric and loop (#1540)
9670e00 
* support new loops

* refactor base sample wise metrics, FID and IS

* adopt configs to new loops

* refine EditLoops and add docstring and unit test for EditLoops

* rename GenEvaluator to EditEvaluator

* revise configs for new EditLoops and EditEvaluator

* remove unused imported modules

* revise unit test of BaseSampleWiseMetric

* remove GenDataPreprocessor, GenLoop from configs, docstrings and tutorials

* avoid raise duplicate conversion warning in EditDataprocessor

* revise channel order conversion in FID metric

* rename GenLogProcessor and GenIterTimeHook to EditLogProcessor and EditIterTimeHook

* rename some elements in default_runtime

* support non-scalar in get_log_after_epoch as MMEngine's LogProcessor

* save metainfo in Resize for outkeys

* complete prepare method for Matting metrics

* remove GenLoop, MutliLoop, GenDataPreprocessor

* remove PixelData
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zengyh1900 zengyh1900 zengyh1900 requested changes

@Z-Fran Z-Fran Z-Fran approved these changes

@liuwenran liuwenran Awaiting requested review from liuwenran

@plyfager plyfager Awaiting requested review from plyfager

@VongolaWu VongolaWu Awaiting requested review from VongolaWu

Assignees

@LeoXing1996 LeoXing1996

Labels
kind/enhancement refactoring, improving CI, template, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LeoXing1996 @zengyh1900 @Z-Fran