Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mmengine.basemodole instead of nn.module #1434

Merged
merged 2 commits into from
Jul 18, 2023

Conversation

plyfager
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

Who can help? @ them here!

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@plyfager plyfager linked an issue Nov 14, 2022 that may be closed by this pull request
21 tasks
@plyfager plyfager linked an issue Nov 14, 2022 that may be closed by this pull request
8 tasks
@plyfager plyfager changed the title BaseModule Use mmengine.basemodole instead of nn.module Nov 14, 2022
@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (51b2847) 82.30% compared to head (f69f2b5) 82.31%.

❗ Current head f69f2b5 differs from pull request most recent head 31c743e. Consider uploading reports for the commit 31c743e to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1434   +/-   ##
=======================================
  Coverage   82.30%   82.31%           
=======================================
  Files         416      416           
  Lines       27954    27966   +12     
  Branches     4375     4375           
=======================================
+ Hits        23008    23020   +12     
  Misses       3997     3997           
  Partials      949      949           
Flag Coverage Δ
unittests 82.31% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmagic/models/editors/stylegan1/stylegan_utils.py 100.00% <ø> (ø)
mmagic/models/editors/lsgan/lsgan_discriminator.py 100.00% <100.00%> (ø)
mmagic/models/editors/lsgan/lsgan_generator.py 94.00% <100.00%> (+0.12%) ⬆️
...els/editors/mspie/mspie_stylegan2_discriminator.py 100.00% <100.00%> (ø)
.../models/editors/mspie/mspie_stylegan2_generator.py 48.55% <100.00%> (+0.29%) ⬆️
...ic/models/editors/mspie/mspie_stylegan2_modules.py 45.45% <100.00%> (+0.50%) ⬆️
mmagic/models/editors/mspie/positional_encoding.py 81.72% <100.00%> (ø)
mmagic/models/editors/pggan/pggan_discriminator.py 87.95% <100.00%> (+0.14%) ⬆️
mmagic/models/editors/pggan/pggan_generator.py 86.66% <100.00%> (+0.14%) ⬆️
mmagic/models/editors/pggan/pggan_modules.py 91.17% <100.00%> (ø)
... and 11 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zengyh1900 zengyh1900 assigned plyfager and unassigned LeoXing1996 Nov 15, 2022
@zengyh1900 zengyh1900 marked this pull request as draft November 16, 2022 09:09
@zengyh1900 zengyh1900 self-requested a review July 18, 2023 04:07
@zengyh1900 zengyh1900 changed the base branch from dev-1.x to main July 18, 2023 07:58
@zengyh1900 zengyh1900 force-pushed the plyfager/BaseModule branch from c1c28a3 to c45a292 Compare July 18, 2023 08:37
@zengyh1900 zengyh1900 marked this pull request as ready for review July 18, 2023 09:32
@zengyh1900 zengyh1900 merged commit 01417a1 into open-mmlab:main Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use mmengine.basemodole instead of nn.module
3 participants