Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init fp16 support #139

Merged
merged 5 commits into from
Sep 22, 2020
Merged

Init fp16 support #139

merged 5 commits into from
Sep 22, 2020

Conversation

nbei
Copy link
Collaborator

@nbei nbei commented Sep 21, 2020

No description provided.

@codecov
Copy link

codecov bot commented Sep 21, 2020

Codecov Report

Merging #139 into master will decrease coverage by 0.07%.
The diff coverage is 71.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
- Coverage   82.32%   82.25%   -0.08%     
==========================================
  Files         143      145       +2     
  Lines        6621     6711      +90     
  Branches      986      994       +8     
==========================================
+ Hits         5451     5520      +69     
- Misses       1071     1090      +19     
- Partials       99      101       +2     
Flag Coverage Δ
#unittests 82.25% <71.62%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmedit/utils/collect_env.py 0.00% <0.00%> (ø)
mmedit/version.py 58.33% <58.33%> (ø)
...ackbones/encoder_decoders/pconv_encoder_decoder.py 45.83% <66.66%> (+0.37%) ⬆️
mmedit/__init__.py 73.68% <73.68%> (-26.32%) ⬇️
...s/backbones/encoder_decoders/gl_encoder_decoder.py 82.14% <100.00%> (+1.37%) ⬆️
...ones/encoder_decoders/two_stage_encoder_decoder.py 55.00% <100.00%> (+2.36%) ⬆️
mmedit/models/inpaintors/one_stage.py 30.76% <100.00%> (+1.16%) ⬆️
mmedit/models/mattors/dim.py 80.76% <100.00%> (+1.17%) ⬆️
mmedit/models/mattors/gca.py 93.75% <100.00%> (+0.64%) ⬆️
mmedit/models/mattors/indexnet.py 84.84% <100.00%> (+1.51%) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7253ba8...b413f94. Read the comment docs.

@nbei nbei requested a review from hellock September 21, 2020 14:53
# support fp16
self.fp16_enabled = False

@auto_fp16(apply_to=('x', ))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@auto_fp16() should be enough

# support fp16
self.fp16_enabled = False

@auto_fp16(apply_to=('x', 'mask_in'))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here

# support fp16
self.fp16_enabled = False

@auto_fp16(apply_to=('x', ))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here

# support fp16
self.fp16_enabled = False

@auto_fp16(apply_to=('x', 'refine'))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here

@hellock hellock merged commit fd64db1 into open-mmlab:master Sep 22, 2020
wchstrife pushed a commit to wchstrife/mmediting that referenced this pull request Dec 26, 2020
* unfinished stage

* support fp16

* fix comment from ck

* fix comment from ck

* fix comment from ck

Co-authored-by: nbei <[email protected]>
Yshuo-Li pushed a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
* unfinished stage

* support fp16

* fix comment from ck

* fix comment from ck

* fix comment from ck

Co-authored-by: nbei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants