Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add niqe metric #114

Merged
merged 7 commits into from
Jul 20, 2020
Merged

add niqe metric #114

merged 7 commits into from
Jul 20, 2020

Conversation

xinntao
Copy link
Collaborator

@xinntao xinntao commented Jul 20, 2020

No description provided.

@xinntao xinntao requested a review from hejm37 July 20, 2020 09:57
hejm37
hejm37 reviewed Jul 20, 2020
View reviewed changes
mmedit/core/evaluation/metrics.py Outdated Show resolved Hide resolved
mmedit/core/evaluation/metrics.py Outdated Show resolved Hide resolved
mmedit/core/evaluation/metrics.py Outdated Show resolved Hide resolved
mmedit/core/evaluation/metrics.py Show resolved Hide resolved
mmedit/core/evaluation/metrics.py Outdated Show resolved Hide resolved
mmedit/core/evaluation/metrics.py Outdated Show resolved Hide resolved
mmedit/core/evaluation/metrics.py Outdated Show resolved Hide resolved
mmedit/core/evaluation/metrics.py Outdated Show resolved Hide resolved
tests/test_metrics.py Show resolved Hide resolved
hejm37
hejm37 reviewed Jul 20, 2020
View reviewed changes
setup.cfg Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 20, 2020 •
edited
Loading

Codecov Report

Merging #114 into master will increase coverage by 0.18%.
The diff coverage is 98.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
+ Coverage   82.24%   82.43%   +0.18%     
==========================================
  Files         143      143              
  Lines        6517     6574      +57     
  Branches      971      976       +5     
==========================================
+ Hits         5360     5419      +59     
+ Misses       1060     1059       -1     
+ Partials       97       96       -1
Flag Coverage Δ
#unittests 82.43% <98.66%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmedit/core/evaluation/metrics.py 95.54% <98.64%> (+1.79%) ⬆️
mmedit/core/evaluation/__init__.py 100.00% <100.00%> (ø)
mmedit/datasets/pipelines/matting_aug.py 95.13% <0.00%> (+0.02%) ⬆️
mmedit/datasets/pipelines/utils.py 100.00% <0.00%> (+7.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58037fd...3a448e0. Read the comment docs.

hejm37
hejm37 reviewed Jul 20, 2020
View reviewed changes
setup.cfg Outdated Show resolved Hide resolved
@hejm37 hejm37 merged commit f9e1453 into open-mmlab:master Jul 20, 2020
@xinntao xinntao deleted the add_niqe branch August 19, 2020 06:40
wchstrife pushed a commit to wchstrife/mmediting that referenced this pull request Dec 26, 2020
@xinntao @hejm37
add niqe metric (open-mmlab#114)
f09c257 
* add niqe

* update test

* update tests

* updates

* updates

* Update setup.cfg

Co-authored-by: Jiamin <[email protected]>
Co-authored-by: Jiamin <[email protected]>
Yshuo-Li pushed a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
@xinntao @hejm37
add niqe metric (open-mmlab#114)
769543b 
* add niqe

* update test

* update tests

* updates

* updates

* Update setup.cfg

Co-authored-by: Jiamin <[email protected]>
Co-authored-by: Jiamin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hejm37 hejm37 hejm37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xinntao @hejm37