Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Support Secondary model mentioned in disco-diffusion #1290

Closed
plyfager opened this issue Oct 12, 2022 · 1 comment
Closed

[Feature] Support Secondary model mentioned in disco-diffusion #1290

plyfager opened this issue Oct 12, 2022 · 1 comment
Assignees
@plyfager
Labels
kind/feature request new feature/model/datasets/config etc. priority/P0 highest priority status/need confirm need confirmed
Milestone
1.0.0rc3

Comments

@plyfager
Copy link
Collaborator

plyfager commented Oct 12, 2022 •
edited
Loading

What is the problem this feature will solve?

Support seconary model mentioned in disco-diffusion https://github.com/alembics/disco-diffusion/blob/main/disco.py#L1760.
Disco-Diffusion is supporting in this PR #1234.

What is the feature?

Based on Disco-Diffusion is supporting in this PR #1234, make a PR to offer secondary model for disco.
This is basically a model used to save memory and time for gradient computing.

What alternatives have you considered?

No response
@plyfager plyfager added the kind/feature request new feature/model/datasets/config etc. label Oct 12, 2022
@zengyh1900 zengyh1900 added this to the Backlog milestone Oct 14, 2022
@zengyh1900 zengyh1900 added priority/P0 highest priority status/need confirm need confirmed labels Oct 14, 2022
@plyfager
Copy link
Collaborator Author

plyfager commented Nov 3, 2022

Fixed in #1368

@plyfager plyfager closed this as completed Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plyfager plyfager

Labels
kind/feature request new feature/model/datasets/config etc. priority/P0 highest priority status/need confirm need confirmed
Projects
None yet
Milestone
1.0.0rc3
Development

No branches or pull requests
2 participants
@zengyh1900 @plyfager