Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mustache linter / vnu & java versions / warnings & checks #108

Open
stronk7 opened this issue Dec 16, 2019 · 1 comment
Open

mustache linter / vnu & java versions / warnings & checks #108

stronk7 opened this issue Dec 16, 2019 · 1 comment

Comments

@stronk7
Copy link

stronk7 commented Dec 16, 2019

Somehow related with #91 ...

it seems that current local_ci vnu version installed (18.11.5) has some problems with java11, more exactly it emits the following warning that breaks output Warning: Nashorn engine is planned to be removed from a future JDK release.

So, right now, we are trying to reproduce that with local_ci (adding 1 specific assertion to check if the warning is emitted):

https://travis-ci.org/stronk7/moodle-local_ci/builds/625923516

And, also, we are trying with the same assertion plus vnu updated to (19.9.4) to see if that avoids the warning:

https://travis-ci.org/stronk7/moodle-local_ci/builds/625921197

Apart from the results there (they are running right now), what has surprised us is that check within moodle-plugin-ci:

https://github.com/blackboard-open-source/moodle-plugin-ci/blob/master/src/Command/MustacheCommand.php#L118-L120

Apparently... it's looking for way older versions, so not sure how current (or future) ones can work at all.

So, just creating this to comment about the vnu/java problems, how we are looking forward fixing them in local_ci (note that there is also a -Dnashorn.args="--no-deprecation-warning" switch to avoid it... but better if we can get a fully working version... so trying that first. And, specially about the apparent outdated check.

Ciao :-)

@stronk7
Copy link
Author

stronk7 commented Dec 16, 2019

Aha, so the 2 travis runs above (vnu 18 and 19) passed ok, hence they are not subject to the Nashorn warning. Cool!

Still moodle-plugin-ci seems to require older (exposed to the 'Nashorn warning`) version 17.

Uhm...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant