chore: javadoc and tests for api, context #942
Conversation
toddbaert
force-pushed
the
chore/more-tests-and-doc
branch
from
3a5bc97 to
e43f7c8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #942 +/- ##
============================================
+ Coverage 95.04% 95.27% +0.22%
- Complexity 392 393 +1
============================================
Files 38 38
Lines 888 888
Branches 54 54
============================================
+ Hits 844 846 +2
+ Misses 24 23 -1
+ Partials 20 19 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| assertEquals("4", merged.getValue("common5").asString(), "invocation merge is incorrect"); | ||
| assertEquals("4", merged.getValue("common6").asString(), "invocation merge is incorrect"); | ||
|
|
||
| c.getBooleanValue("key", false, invocationCtx); |
There was a problem hiding this comment.
instead of the specific "getMergedContext" method, I simply used a spy here.
| @@ -17,18 +15,13 @@ public DoSomethingProvider(ImmutableMetadata flagMetadata) { | |||
| this.flagMetadata = flagMetadata; | |||
| } | |||
|
|
|||
| EvaluationContext getMergedContext() { | |||
There was a problem hiding this comment.
This method is no longer needed, spies work better.
There was a problem hiding this comment.
Nice set of improvements
Please see this to avoid conflicts in documentation
|
@toddbaert I think this can be rebased an considered for 1.8.1 release :) |
Signed-off-by: Todd Baert <[email protected]>
toddbaert
force-pushed
the
chore/more-tests-and-doc
branch
from
716b105 to
638db9c
Compare
Signed-off-by: Todd Baert <[email protected]>
|
This PR contains no functional changes, it:
fixes: #939