feat: implemented structured logging #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #54 +/- ##
==========================================
- Coverage 92.60% 90.85% -1.75%
==========================================
Files 5 6 +1
Lines 284 361 +77
==========================================
+ Hits 263 328 +65
- Misses 20 32 +12
Partials 1 1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Skye Gill <[email protected]>
skyerus
force-pushed
the
issue-46_logging
branch
from
ad176d6
to
59cff96
Compare
james-milligan
approved these changes
Sep 1, 2022
Signed-off-by: Skye Gill <[email protected]>
toddbaert
reviewed
Sep 1, 2022
toddbaert
approved these changes
Sep 1, 2022
Co-authored-by: Todd Baert <[email protected]> Signed-off-by: Skye Gill <[email protected]>
That would be something for the application author to decide, there's nothing stopping them from placing a logger inside their hook struct and using it in the callbacks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.