Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolution error only includes the code #96

Merged
merged 2 commits into from
Oct 7, 2022

Conversation

rcrowe
Copy link
Contributor

@rcrowe rcrowe commented Oct 7, 2022

This PR

Adds the error message to the formatted error string.
Makes it clear when logged that the error originates from the OpenFeature SDK.

Related Issues

Fixes #94

@rcrowe rcrowe changed the title Improve error formating fix: resolution error only includes the code Oct 7, 2022
Signed-off-by: Rob Crowe <[email protected]>
Revert accidental change

Signed-off-by: Rob Crowe <[email protected]>
Copy link
Contributor

@skyerus skyerus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks!

pkg/openfeature/logger.go Show resolved Hide resolved
@beeme1mr beeme1mr merged commit 524b054 into open-feature:main Oct 7, 2022
@rcrowe rcrowe deleted the improve-error-format branch October 8, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Improve default error logging
3 participants