Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: replaced EvaluationOptions with variadic option setter in client functions #77

Merged
merged 2 commits into from
Sep 23, 2022

Conversation

skyerus
Copy link
Contributor

@skyerus skyerus commented Sep 23, 2022

Signed-off-by: Skye Gill [email protected]

@codecov-commenter
Copy link

Codecov Report

Merging #77 (4ff8491) into main (aa59b35) will decrease coverage by 4.16%.
The diff coverage is 64.70%.

@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
- Coverage   84.30%   80.14%   -4.17%     
==========================================
  Files           6        6              
  Lines         376      418      +42     
==========================================
+ Hits          317      335      +18     
- Misses         54       70      +16     
- Partials        5       13       +8     
Impacted Files Coverage Δ
pkg/openfeature/openfeature.go 90.69% <ø> (-0.97%) ⬇️
pkg/openfeature/client.go 78.52% <64.70%> (-5.55%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@toddbaert toddbaert self-requested a review September 23, 2022 14:24
Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but will conflict with #75 I think.

I think you might want to merge that first, then absorb the changes here. Once you do, don't forget to update the godoc.

@skyerus skyerus merged commit fc4b871 into open-feature:main Sep 23, 2022
@skyerus skyerus deleted the issue-62_client-options branch September 23, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Review and simplify application author facing APIs if possible
5 participants