-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: replaced EvaluationOptions with variadic option setter in client functions #77
Conversation
Codecov Report
@@ Coverage Diff @@
## main #77 +/- ##
==========================================
- Coverage 84.30% 80.14% -4.17%
==========================================
Files 6 6
Lines 376 418 +42
==========================================
+ Hits 317 335 +18
- Misses 54 70 +16
- Partials 5 13 +8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but will conflict with #75 I think.
I think you might want to merge that first, then absorb the changes here. Once you do, don't forget to update the godoc.
…nt functions Signed-off-by: Skye Gill <[email protected]>
Signed-off-by: Skye Gill <[email protected]>
4ff8491
to
679a009
Compare
Signed-off-by: Skye Gill [email protected]