refactor!: defined type for provider interface evaluation context #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James-Milligan <[email protected]>
|
Intention is to reduce confusion and ensure the change looks more deliberate |
skyerus
reviewed
Sep 22, 2022
Signed-off-by: James-Milligan <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #74 +/- ##
=======================================
Coverage 80.14% 80.14%
=======================================
Files 6 6
Lines 418 418
=======================================
Hits 335 335
Misses 70 70
Partials 13 13
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
beeme1mr
approved these changes
Sep 22, 2022
toddbaert
reviewed
Sep 22, 2022
Signed-off-by: James-Milligan <[email protected]>
skyerus
approved these changes
Sep 27, 2022
Signed-off-by: James-Milligan <[email protected]>
This was referenced Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: James-Milligan [email protected]