Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provider client 1:n binding support #190

Merged
merged 21 commits into from
Jul 14, 2023

Conversation

Kavindu-Dodan
Copy link
Contributor

@Kavindu-Dodan Kavindu-Dodan commented Jun 27, 2023

This PR

A follow up PR to introduce 1:N support - Check diff from main

Fixes and completes #186

A follow-up for the PR #188

This PR brings,

  • 1 to N binding of provider (a single provider to multiple client binding capability)
  • completes eventing specification by adding API-level events for success/error initialization
  • Improves the eventing implementation and adds more tests

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #190 (c69a27c) into main (220dc33) will increase coverage by 1.92%.
The diff coverage is 97.51%.

❗ Current head c69a27c differs from pull request most recent head 337536c. Consider uploading reports for the commit 337536c to get more accurate results

@@            Coverage Diff             @@
##             main     #190      +/-   ##
==========================================
+ Coverage   77.03%   78.95%   +1.92%     
==========================================
  Files           9        9              
  Lines         997     1074      +77     
==========================================
+ Hits          768      848      +80     
+ Misses        207      204       -3     
  Partials       22       22              
Impacted Files Coverage Δ
pkg/openfeature/provider.go 65.38% <0.00%> (-2.62%) ⬇️
pkg/openfeature/event_executor.go 98.71% <98.14%> (+2.37%) ⬆️
pkg/openfeature/api.go 92.41% <100.00%> (+2.32%) ⬆️
pkg/openfeature/openfeature.go 97.67% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Kavindu-Dodan Kavindu-Dodan force-pushed the chore/1-to-n-handling branch 2 times, most recently from 53198aa to d371d15 Compare June 29, 2023 21:46
@Kavindu-Dodan Kavindu-Dodan marked this pull request as ready for review June 29, 2023 21:53
@Kavindu-Dodan Kavindu-Dodan requested a review from a team as a code owner June 29, 2023 21:53
@Kavindu-Dodan Kavindu-Dodan force-pushed the chore/1-to-n-handling branch 2 times, most recently from b911ab7 to c847651 Compare June 30, 2023 16:05
@toddbaert toddbaert self-requested a review July 4, 2023 18:02
Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. I don't see any issues from a spec perspective. The testing is very robust. I had a nit about some of the tests here, but if this is more effort than it's worth I'm fine with leaving it as is, though perhaps with a comment we're testing a private API as a proxy for a public one.

@Kavindu-Dodan Kavindu-Dodan force-pushed the chore/1-to-n-handling branch 2 times, most recently from be534e8 to 144dcbd Compare July 4, 2023 21:30
Copy link

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Kavindu-Dodan and others added 13 commits July 14, 2023 14:38
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Co-authored-by: Todd Baert <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Co-authored-by: Todd Baert <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Co-authored-by: Todd Baert <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
@Kavindu-Dodan Kavindu-Dodan changed the title chore: provider client 1:n binding support feat: provider client 1:n binding support Jul 14, 2023
Signed-off-by: Kavindu Dodanduwa <[email protected]>
@Kavindu-Dodan Kavindu-Dodan merged commit 940cb8b into open-feature:main Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants