-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: provider client 1:n binding support #190
feat: provider client 1:n binding support #190
Conversation
Codecov Report
@@ Coverage Diff @@
## main #190 +/- ##
==========================================
+ Coverage 77.03% 78.95% +1.92%
==========================================
Files 9 9
Lines 997 1074 +77
==========================================
+ Hits 768 848 +80
+ Misses 207 204 -3
Partials 22 22
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
53198aa
to
d371d15
Compare
b911ab7
to
c847651
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. I don't see any issues from a spec perspective. The testing is very robust. I had a nit about some of the tests here, but if this is more effort than it's worth I'm fine with leaving it as is, though perhaps with a comment we're testing a private API as a proxy for a public one.
be534e8
to
144dcbd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
f5942f3
to
d76a5e1
Compare
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Co-authored-by: Todd Baert <[email protected]> Signed-off-by: Kavindu Dodanduwa <[email protected]>
Co-authored-by: Todd Baert <[email protected]> Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Co-authored-by: Todd Baert <[email protected]> Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
d76a5e1
to
c69a27c
Compare
Signed-off-by: Kavindu Dodanduwa <[email protected]>
This PR
A follow up PR to introduce 1:N support - Check diff from main
Fixes and completes #186
A follow-up for the PR #188
This PR brings,