Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: support OFO v1beta1 API #997

Merged
merged 7 commits into from
Nov 14, 2023
Merged

feat!: support OFO v1beta1 API #997

merged 7 commits into from
Nov 14, 2023

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Nov 8, 2023 •
edited
Loading

This PR

  • supports OFO v1beta1 API

Related Issues

Fixes #983

Test

Tested with OFO, green run here, note that OFO e2e tests are using custom build image of flagd, here

Follow-up

#998

Notes

  • currently the OFO dependency is pointing to the (currently) latest commit in main branch of OFO

@netlify Netlify
Copy link

netlify bot commented Nov 8, 2023 •
edited
Loading

✅ Deploy Preview for polite-licorice-3db33c ready!

Name Link
🔨 Latest commit 2bd4802
🔍 Latest deploy log https://app.netlify.com/sites/polite-licorice-3db33c/deploys/655312fca6bd8f000817a687
😎 Deploy Preview https://deploy-preview-997--polite-licorice-3db33c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov Codecov
Copy link

codecov bot commented Nov 8, 2023 •
edited
Loading

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (e9347cc) 72.63% compared to head (2bd4802) 71.96%.
Report is 2 commits behind head on main.

Files Patch % Lines
core/pkg/sync/kubernetes/kubernetes_sync.go 62.50% 4 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #997      +/-   ##
==========================================
- Coverage   72.63%   71.96%   -0.68%     
==========================================
  Files          28       28              
  Lines        2858     2864       +6     
==========================================
- Hits         2076     2061      -15     
- Misses        685      699      +14     
- Partials       97      104       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odubajDT odubajDT mentioned this pull request Nov 8, 2023
Merged
@odubajDT odubajDT marked this pull request as ready for review November 8, 2023 10:55
@odubajDT odubajDT requested a review from a team as a code owner November 8, 2023 10:55
@odubajDT odubajDT requested a review from thisthat November 9, 2023 11:27
Kavindu-Dodan
Kavindu-Dodan previously requested changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@Kavindu-Dodan Kavindu-Dodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am marking this as request changes because of below reasons,

  • We need to make this PR a breaking change
  • Need to update other documentaion references [1]

Otherwise changes looks good.

[1] - https://github.com/open-feature/flagd/tree/main/docs/reference/openfeature-operator

@odubajDT
Copy link
Contributor Author

I am marking this as request changes because of below reasons,

* We need to make this PR a breaking change

* Need to update other documentaion references [1]

Otherwise changes looks good.

[1] - https://github.com/open-feature/flagd/tree/main/docs/reference/openfeature-operator

Docs adapted, can you please describe how the breaking change is added?

@thisthat thisthat changed the title feat: support OFO v1beta1 API feat!: support OFO v1beta1 API Nov 10, 2023
@thisthat
Copy link
Member

Docs adapted, can you please describe how the breaking change is added?

FlagD uses release-please to handle the changelog. I marked the PR as breaking change by adding ! to the title.
You can see more info here: https://github.com/googleapis/release-please#how-should-i-write-my-commits

@odubajDT
Copy link
Contributor Author

Docs adapted, can you please describe how the breaking change is added?

FlagD uses release-please to handle the changelog. I marked the PR as breaking change by adding ! to the title. You can see more info here: https://github.com/googleapis/release-please#how-should-i-write-my-commits

Thank you!

@toddbaert
Copy link
Member

@odubajDT @thisthat @Kavindu-Dodan @beeme1mr

I believe once we merge this, we won't be able to update the flagd version OFO uses until OFO is made compatible with this flagd (which I believe is done here). @odubajDT please confirm.

toddbaert
toddbaert reviewed Nov 13, 2023
View reviewed changes
flagd/cmd/start.go Outdated Show resolved Hide resolved
toddbaert
toddbaert approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, and thanks!

I think I see some minor doc discrepancies, which I've noted.

@odubajDT
Copy link
Contributor Author

@odubajDT @thisthat @Kavindu-Dodan @beeme1mr

I believe once we merge this, we won't be able to update the flagd version OFO uses until OFO is made compatible with this flagd (which I believe is done here). @odubajDT please confirm.

Right, OFO needs to use the version of flagd and flagd-proxy which contains this PR. Would it be possible to make a release here ? If not we can use a dev build until official release will be made.

@odubajDT
feat: support OFO v1beta1 API
59bee92 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
fix tests
08ff09e 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
fix docs
bec3323 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
move dep to main branch
08a0899 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
pr review
efce742 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
update docs
f47ee7e 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
adapt misses in docs
2bd4802 
Signed-off-by: odubajDT <[email protected]>
@odubajDT odubajDT merged commit bb6f5bf into open-feature:main Nov 14, 2023
12 of 15 checks passed
@github-actions github-actions bot mentioned this pull request Nov 14, 2023
Merged
toddbaert pushed a commit that referenced this pull request Nov 15, 2023
@github-actions
chore: release main (#1007)
cfcd6bd 
🤖 I have created a release *beep* *boop*
---


<details><summary>flagd: 0.7.0</summary>

##
[0.7.0](flagd/v0.6.8...flagd/v0.7.0)
(2023-11-15)


### ⚠ BREAKING CHANGES

* OFO APIs were updated to version v1beta1, since they are more stable
now. Resources of the alpha versions are no longer supported in flagd or
flagd-proxy.

### 🐛 Bug Fixes

* **deps:** update module
github.com/open-feature/go-sdk-contrib/providers/flagd to v0.1.18
([#1011](#1011))
([90d4e4e](90d4e4e))


### ✨ New Features

* support OFO v1beta1 API
([#997](#997))
([bb6f5bf](bb6f5bf))


### 🧹 Chore

* move e2e tests to test
([#1005](#1005))
([a94b639](a94b639))
</details>

<details><summary>flagd-proxy: 0.3.0</summary>

##
[0.3.0](flagd-proxy/v0.2.13...flagd-proxy/v0.3.0)
(2023-11-15)


### ⚠ BREAKING CHANGES

* OFO APIs were updated to version v1beta1, since they are more stable
now. Resources of the alpha versions are no longer supported in flagd or
flagd-proxy.

### 🐛 Bug Fixes

* **deps:** update module github.com/open-feature/flagd/core to v0.6.8
([#1006](#1006))
([c9b48bd](c9b48bd))


### ✨ New Features

* support OFO v1beta1 API
([#997](#997))
([bb6f5bf](bb6f5bf))


### 🧹 Chore

* move e2e tests to test
([#1005](#1005))
([a94b639](a94b639))
</details>

<details><summary>core: 0.7.0</summary>

##
[0.7.0](core/v0.6.8...core/v0.7.0)
(2023-11-15)


### ⚠ BREAKING CHANGES

* OFO APIs were updated to version v1beta1, since they are more stable
now. Resources of the alpha versions are no longer supported in flagd or
flagd-proxy.

### ✨ New Features

* support OFO v1beta1 API
([#997](#997))
([bb6f5bf](bb6f5bf))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request Dec 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toddbaert toddbaert toddbaert approved these changes

@thisthat thisthat thisthat approved these changes

@Kavindu-Dodan Kavindu-Dodan Awaiting requested review from Kavindu-Dodan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Support v1beta1 API of OFO
4 participants
@odubajDT @thisthat @toddbaert @Kavindu-Dodan