fix: fixes store merge when selector is used #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kavindu Dodanduwa <[email protected]>
dosubot
bot
added
the
size:L
✅ Deploy Preview for polite-licorice-3db33c canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1322 +/- ##
==========================================
+ Coverage 73.69% 78.74% +5.05%
==========================================
Files 32 36 +4
Lines 3140 2828 -312
==========================================
- Hits 2314 2227 -87
+ Misses 717 466 -251
- Partials 109 135 +26 ☔ View full report in Codecov by Sentry. |
thisthat
approved these changes
Jun 6, 2024
Merged
toddbaert
pushed a commit
that referenced
this pull request
Jun 6, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>flagd: 0.10.3</summary> ## [0.10.3](flagd/v0.10.2...flagd/v0.10.3) (2024-06-06) ### 🧹 Chore * adapt telemetry setup error handling ([#1315](#1315)) ([20bcb78](20bcb78)) * fix unit tests and ensure their execution ([#1316](#1316)) ([25041c0](25041c0)) </details> <details><summary>core: 0.9.3</summary> ## [0.9.3](core/v0.9.2...core/v0.9.3) (2024-06-06) ### 🐛 Bug Fixes * fixes store merge when selector is used ([#1322](#1322)) ([ed5025d](ed5025d)) ### 🧹 Chore * adapt telemetry setup error handling ([#1315](#1315)) ([20bcb78](20bcb78)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
This change address open-feature/open-feature-operator#664.
Background
We allow using multiple flag source CRDs when using flagd-proxy with OFO. Internally, this converts to flagd using gRPC syncs with scopes, where scopes specify the CRD names that need to source flags from.
Bug
We had two bugs, first gRPC resyncs never contained
scope. This is why we observedunable to build sync from URI for targetmessage. Secondly, we triggered resyncs only considering source equility. This is not valid with flagd-proxy as we always go through the proxy for any CRD.Fix
Fix here adds scope to gRPC resyncs and considers both source and selector equality when triggering a resync
How to validate the fix
Use this image with OFO sidecar image override
helm upgrade --install openfeature openfeature/open-feature-operator --set sidecarConfiguration.image.tag=1,sidecarConfiguration.image.repository=kavindudodanduwa/flagd