Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Improve telemetry error handling #1194

Closed
Kavindu-Dodan opened this issue Feb 2, 2024 · 0 comments · Fixed by #1315
Closed

[FEATURE] Improve telemetry error handling #1194

Kavindu-Dodan opened this issue Feb 2, 2024 · 0 comments · Fixed by #1315
Labels
contribfest A good issue for Contribfest KubeCon EU '24 enhancement New feature or request

Comments

@Kavindu-Dodan
Copy link
Contributor

Requirements

Consider this conversation - #1188 (comment)

In the current implementation, errors in telemetry at the startup phase result in startup failure. While this has benefits, telemetry can be considered as non-critical sub-system and allow flagd/flagd-proxy to startup with warnings.

AC

Revisit configuration and startup logic. Migrate from fail fast to log and continue for telemetry errors.
@Kavindu-Dodan Kavindu-Dodan added enhancement New feature or request Needs Triage This issue needs to be investigated by a maintainer labels Feb 2, 2024
@Kavindu-Dodan Kavindu-Dodan mentioned this issue Feb 2, 2024
Merged
@toddbaert toddbaert added contribfest A good issue for Contribfest KubeCon EU '24 and removed Needs Triage This issue needs to be investigated by a maintainer labels Mar 11, 2024
@bacherfl bacherfl mentioned this issue May 22, 2024
Merged
toddbaert pushed a commit that referenced this issue May 27, 2024
@bacherfl
chore: adapt telemetry setup error handling (#1315)
20bcb78 
Closes #1194

This PR adapts the service setup to not fail when encountering an error
in the telemetry setup.

---------

Signed-off-by: Florian Bacher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contribfest A good issue for Contribfest KubeCon EU '24 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: adapt telemetry setup error handling bacherfl/flagd
2 participants
@Kavindu-Dodan @toddbaert