-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: deadlocks in client applications #150
fix: deadlocks in client applications #150
Conversation
Codecov Report
@@ Coverage Diff @@
## main #150 +/- ##
=======================================
Coverage 93.91% 93.91%
=======================================
Files 20 20
Lines 542 542
Branches 39 39
=======================================
Hits 509 509
Misses 20 20
Partials 13 13
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just need to rebase and sign your commit https://github.com/open-feature/dotnet-sdk/pull/150/checks?check_run_id=16907801522
Ya @DouglasHammon-FV sorry for the tedium, but this is a CNCF requirement. Thanks for the quick fix! |
I've updated the title a bit (it's included in release notes, as well as a link to this PR). |
bugfix(feature-client): Added configure await to avoid deadlocks when executing synchronously Signed-off-by: DouglasHammon-FV <[email protected]>
fb1aab4
to
e261d9b
Compare
@toddbaert I have signed the commit. But code coverage is failing now. Looks like an issue with uploading stuff. I don't know how to kickoff that again (manually). Please review. |
This is a transient error. I re-ran and it worked. merging now! |
@toddbaert Thanks! When can I expect a new release with these changes? |
Shortly after the automated release PR is merged. Since this is the only change I will do so as soon as the CI passes.. |
Thanks for reporting (and fixing) this issue @DouglasHammon-FV! |
This PR
-Added configure await false to avoid deadlocks when executing synchronously from client applications.
Related Issues
Fixes #149
Notes
I published a Nuget package locally and confirmed this fixes the deadlock issue that I'm seeing in my project.