Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deadlocks in client applications #150

Conversation

DouglasHammon-FV
Copy link
Contributor

This PR

-Added configure await false to avoid deadlocks when executing synchronously from client applications.

Related Issues

Fixes #149

Notes

I published a Nuget package locally and confirmed this fixes the deadlock issue that I'm seeing in my project.

@DouglasHammon-FV DouglasHammon-FV requested a review from a team as a code owner September 19, 2023 00:09
@DouglasHammon-FV DouglasHammon-FV changed the title bugfix(feature-client): Added configure await to avoid deadlocks when executing synchronously fix(feature-client): Added configure await to avoid deadlocks when executing synchronously Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #150 (e261d9b) into main (598270d) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #150   +/-   ##
=======================================
  Coverage   93.91%   93.91%           
=======================================
  Files          20       20           
  Lines         542      542           
  Branches       39       39           
=======================================
  Hits          509      509           
  Misses         20       20           
  Partials       13       13           
Files Changed Coverage Δ
src/OpenFeature/OpenFeatureClient.cs 96.10% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@benjiro benjiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@toddbaert
Copy link
Member

LGTM. Just need to rebase and sign your commit https://github.com/open-feature/dotnet-sdk/pull/150/checks?check_run_id=16907801522

Ya @DouglasHammon-FV sorry for the tedium, but this is a CNCF requirement.

Thanks for the quick fix!

@toddbaert toddbaert changed the title fix(feature-client): Added configure await to avoid deadlocks when executing synchronously fix: deadlocks in client applications Sep 19, 2023
@toddbaert
Copy link
Member

toddbaert commented Sep 19, 2023

I've updated the title a bit (it's included in release notes, as well as a link to this PR).

bugfix(feature-client): Added configure await to avoid deadlocks when executing synchronously

Signed-off-by: DouglasHammon-FV <[email protected]>
@DouglasHammon-FV DouglasHammon-FV force-pushed the bugfix/configure-await-for-sync-execution branch from fb1aab4 to e261d9b Compare September 19, 2023 16:03
@DouglasHammon-FV
Copy link
Contributor Author

@toddbaert I have signed the commit. But code coverage is failing now. Looks like an issue with uploading stuff. I don't know how to kickoff that again (manually). Please review.

@toddbaert
Copy link
Member

@toddbaert I have signed the commit. But code coverage is failing now. Looks like an issue with uploading stuff. I don't know how to kickoff that again (manually). Please review.

This is a transient error. I re-ran and it worked. merging now!

@toddbaert toddbaert merged commit 17a7772 into open-feature:main Sep 19, 2023
11 checks passed
@DouglasHammon-FV
Copy link
Contributor Author

@toddbaert Thanks! When can I expect a new release with these changes?

@toddbaert
Copy link
Member

@toddbaert Thanks! When can I expect a new release with these changes?

Shortly after the automated release PR is merged. Since this is the only change I will do so as soon as the CI passes..

@beeme1mr
Copy link
Member

Thanks for reporting (and fixing) this issue @DouglasHammon-FV!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Evaluate feature flag from synchronous code (no async/await support) causes deadlock
5 participants