This repository has been archived by the owner on Nov 28, 2024. It is now read-only.
fix: missing scheme from gitea client #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mend Scan Summary: ❌Repository: open-component-model/mpas-product-controller
|
phoban01
reviewed
Nov 30, 2023
Comment on lines
+91
to
+96
| u, err := v.parseDomainURL(repository.Spec.Domain, repository.Spec.Insecure) | ||
| if err != nil { | ||
| return false, fmt.Errorf("failed to parse repository url %s: %w", repository.Spec.Domain, err) | ||
| } | ||
|
|
||
| domain = u |
There was a problem hiding this comment.
Could this logic go in API as kubebuilder annotation?
+kubebuilder:validation:Pattern="^(http|https)://.*$"
There was a problem hiding this comment.
No, because we specifically disabled that on the repository.
There was a problem hiding this comment.
We don't allow passing in the scheme to the repository because of other bugs that it did.
phoban01
approved these changes
Nov 30, 2023
Comment on lines
+91
to
+96
| u, err := v.parseDomainURL(repository.Spec.Domain, repository.Spec.Insecure) | ||
| if err != nil { | ||
| return false, fmt.Errorf("failed to parse repository url %s: %w", repository.Spec.Domain, err) | ||
| } | ||
|
|
||
| domain = u |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Screenshots
Added tests?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Added to documentation?
Checklist: