Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Chore: Update api dependencies and handle deprecated code. #333

Conversation

xuezhaojun
Copy link
Member

@xuezhaojun xuezhaojun commented Dec 19, 2023

Summary

As api bump to kubernetes 1.28 open-cluster-management-io/api#30, the ocm also need to upgrade the dependencies and fix some deprecated code usage.

Related issue(s)

Fixes #

@openshift-ci openshift-ci bot requested review from elgnay and skeeey December 19, 2023 07:22
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 52 lines in your changes are missing coverage. Please review.

Comparison is base (f89d535) 61.75% compared to head (9e8ddaf) 61.63%.
Report is 5 commits behind head on main.

Files Patch % Lines
pkg/registration/hub/lease/clocksynccontroller.go 42.85% 47 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #333      +/-   ##
==========================================
- Coverage   61.75%   61.63%   -0.13%     
==========================================
  Files         132      133       +1     
  Lines       13992    14083      +91     
==========================================
+ Hits         8641     8680      +39     
- Misses       4585     4632      +47     
- Partials      766      771       +5     
Flag Coverage Δ
unit 61.63% <42.85%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xuezhaojun
Copy link
Member Author

/assign @qiujian16

@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 20, 2023
Copy link
Contributor

openshift-ci bot commented Dec 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, xuezhaojun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 9dc8f10 into open-cluster-management-io:main Dec 20, 2023
14 checks passed
@xuezhaojun xuezhaojun deleted the update-api-dependency branch January 18, 2024 08:50
mprahl pushed a commit to mprahl/OCM that referenced this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants