-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add ClusterAnnotations support. #234
✨ Add ClusterAnnotations support. #234
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #234 +/- ##
=======================================
Coverage 60.29% 60.30%
=======================================
Files 131 132 +1
Lines 13543 13561 +18
=======================================
+ Hits 8166 8178 +12
- Misses 4625 4629 +4
- Partials 752 754 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
94dcc76
to
c19de76
Compare
Signed-off-by: xuezhaojun <[email protected]>
c19de76
to
ba6ebb4
Compare
/assign @qiujian16 |
/approve /assign @zhiweiyin318 @zhujian7 is there any case you want registry to be also set as this? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, xuezhaojun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
emmm, not yet. So far we should only set up the registry from the hub |
/lgtm |
Summary
The feature supports us to assign the annotations**(must have "agent.open-cluster-management.io" as prefix)** when creating a managed cluster from the agent side.
Related issue(s)
open-cluster-management-io/api#252