Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add ClusterAnnotations support. #234

Conversation

xuezhaojun
Copy link
Member

@xuezhaojun xuezhaojun commented Jul 25, 2023

Summary

The feature supports us to assign the annotations**(must have "agent.open-cluster-management.io" as prefix)** when creating a managed cluster from the agent side.

Related issue(s)

open-cluster-management-io/api#252

@openshift-ci openshift-ci bot requested review from ldpliu and skeeey July 25, 2023 16:45
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch coverage: 77.87% and no project coverage change.

Comparison is base (e22faa4) 60.29% compared to head (52606e0) 60.30%.
Report is 1 commits behind head on main.

❗ Current head 52606e0 differs from pull request most recent head ba6ebb4. Consider uploading reports for the commit ba6ebb4 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #234   +/-   ##
=======================================
  Coverage   60.29%   60.30%           
=======================================
  Files         131      132    +1     
  Lines       13543    13561   +18     
=======================================
+ Hits         8166     8178   +12     
- Misses       4625     4629    +4     
- Partials      752      754    +2     
Flag Coverage Δ
unit 60.30% <77.87%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/common/options/agent.go 66.66% <ø> (ø)
pkg/common/options/options.go 100.00% <ø> (ø)
...llers/crdstatuccontroller/crd_status_controller.go 37.31% <ø> (ø)
...sterletcontroller/klusterlet_cleanup_controller.go 55.10% <ø> (ø)
...llers/ssarcontroller/klusterlet_ssar_controller.go 76.98% <ø> (-0.07%) ⬇️
...nt/controllers/scheduling/cluster_event_handler.go 59.25% <ø> (ø)
pkg/placement/debugger/debugger.go 52.63% <ø> (ø)
pkg/registration/clientcert/cert_controller.go 44.39% <ø> (ø)
pkg/registration/clientcert/certificate.go 42.61% <ø> (+1.70%) ⬆️
...stration/spoke/managedcluster/status_controller.go 53.06% <ø> (ø)
... and 39 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xuezhaojun xuezhaojun force-pushed the create-managed-cluster-with-annotation branch 2 times, most recently from 94dcc76 to c19de76 Compare July 26, 2023 03:23
@xuezhaojun xuezhaojun closed this Jul 26, 2023
@xuezhaojun xuezhaojun reopened this Jul 26, 2023
@xuezhaojun xuezhaojun closed this Jul 26, 2023
@xuezhaojun xuezhaojun reopened this Jul 26, 2023
@xuezhaojun xuezhaojun force-pushed the create-managed-cluster-with-annotation branch from c19de76 to ba6ebb4 Compare July 26, 2023 04:19
@xuezhaojun
Copy link
Member Author

/assign @qiujian16

@qiujian16
Copy link
Member

/approve

/assign @zhiweiyin318

@zhujian7 is there any case you want registry to be also set as this?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, xuezhaojun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhujian7
Copy link
Member

is there any case you want registry to be also set as this?

emmm, not yet. So far we should only set up the registry from the hub

@zhiweiyin318
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 27, 2023
@openshift-merge-robot openshift-merge-robot merged commit 142fd5b into open-cluster-management-io:main Jul 27, 2023
@xuezhaojun xuezhaojun deleted the create-managed-cluster-with-annotation branch July 27, 2023 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants