Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Build common options for agent #163

Conversation

qiujian16
Copy link
Member

No description provided.

@openshift-ci openshift-ci bot requested review from jnpacker and mikeshng June 5, 2023 06:13
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 5, 2023
haoqing0110 pushed a commit to haoqing0110/OCM that referenced this pull request Jun 5, 2023
@qiujian16 qiujian16 force-pushed the common-options branch 4 times, most recently from 1f185e1 to 6286f6a Compare June 7, 2023 01:05
@qiujian16 qiujian16 force-pushed the common-options branch 2 times, most recently from a1149b9 to 2777ead Compare June 7, 2023 09:04
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@483612a). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #163   +/-   ##
=======================================
  Coverage        ?   58.46%           
=======================================
  Files           ?      107           
  Lines           ?    11836           
  Branches        ?        0           
=======================================
  Hits            ?     6920           
  Misses          ?     4244           
  Partials        ?      672           
Flag Coverage Δ
unit 58.46% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@qiujian16 qiujian16 changed the title Build common options for agent 🌱 Build common options for agent Jun 8, 2023
@skeeey
Copy link
Member

skeeey commented Jun 8, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 8, 2023
@openshift-merge-robot openshift-merge-robot merged commit 62efbf9 into open-cluster-management-io:main Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants