Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

surface precip product needs fixing: currently flux is computed assuming per-cell value, but data is domain-wide #708

Closed
slayoo opened this issue Dec 16, 2021 · 13 comments · Fixed by #1399
Closed

surface precip product needs fixing: currently flux is computed assuming per-cell value, but data is domain-wide #708

slayoo opened this issue Dec 16, 2021 · 13 comments · Fixed by #1399

Comments

@slayoo
Copy link
Member

slayoo commented Dec 16, 2021

  • is the third dimension in ICMW OK?
  • test badly needed
@github-actions
Copy link

Stale issue message

@github-actions
Copy link

Stale issue message

@github-actions
Copy link

Stale issue message

@github-actions
Copy link

Stale issue message

@github-actions
Copy link

Stale issue message

@github-actions
Copy link

Stale issue message

@github-actions
Copy link

Stale issue message

@github-actions
Copy link

Stale issue message

@github-actions
Copy link

Stale issue message

@github-actions
Copy link

Stale issue message

@github-actions
Copy link

Stale issue message

@slayoo slayoo reopened this Oct 31, 2023
@github-actions GitHub Actions
Copy link

Stale issue message

@github-actions github-actions bot closed this as completed Jan 8, 2024
@slayoo slayoo reopened this Jan 8, 2024
@slayoo slayoo changed the title surface precip product need fixing: currently flux is computed assuming per-cell value, but data is domain-wide surface precip product needs fixing: currently flux is computed assuming per-cell value, but data is domain-wide May 3, 2024
@slayoo
Copy link
Member Author

slayoo commented Oct 8, 2024

addressed in #1399

@slayoo slayoo linked a pull request Oct 8, 2024 that will close this issue
improve test coverage for impl.Mesh and products.SufracePrecipitation; introduce Mesh.domain_bottom_surface_area; switch from volume to mass for rainfall counting; improve docstrings (default length of omitted dims, liquid/ice phase). closes #708 #1399
Merged
@slayoo slayoo closed this as completed in 7c2c00d Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@slayoo