Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jensen & Nugent example TODOs #1266

Open
slayoo opened this issue Feb 7, 2024 · 3 comments
Open

Jensen & Nugent example TODOs #1266

slayoo opened this issue Feb 7, 2024 · 3 comments

Comments

@slayoo
Copy link
Member

slayoo commented Feb 7, 2024

No description provided.

@bhiogade bhiogade changed the title make Yang and Jensen & Nugent parcel initial parameters common (T, p, RH, ...) Jensen & Nugent example TODOs Feb 15, 2024
@bhiogade
Copy link
Contributor

bhiogade commented Feb 15, 2024

  • make Yang and Jensen & Nugent parcel initial parameters common (T, p, RH, ...)
  • introduce a better error message indicating wrong order of dynamics in builder (condensation vs. ambient thermodynamics)
  • double check if the concentrations in Table 3 are for STP conditions or other?
  • more code reuse with other examples (especially G&P 2023 which we have based on)
  • check why rightmost drop from a sampling range is not included when doing Logarithmic sampling
  • figure the best tilmestep setting (not given in the paper)
  • implement and use Bolton SVP formula
  • implement Grabowski et al. 2011 diffusion kinetics K
  • rename formulae to Grabowski et al. 2011
  • check where the Grabowski et al. 2011 diffusion thermics formulae where taken from? (and if found, rename)
  • Fig. 4 smoke test
  • Fig. 5 smoke test
  • Fig. 6 smoke test
  • Fig. 7
  • Fig. 7 smoke test
  • Fig. 8
  • Fig. 8 smoke test
  • Fig. 9
  • Fig. 9 smoke test
  • Fig. 10
  • Fig. 10 smoke test
  • move the badges in the README file from condensation-only to condensation-collisions category

@slayoo
Copy link
Member Author

slayoo commented Feb 17, 2024

@bhiogade, the initial PR, after some code cleanups (README file badges, renaming the formulae to Grabowski et al. 2011), is now merged & released!

Copy link

Stale issue message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants