Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Test List Editor users to view and respond to PR comments/feedback #59

Open
agrabeli opened this issue Jul 27, 2022 · 2 comments
Assignees
Labels
enhancement improving existing code or new feature icebox priority/low user feedback requests that have been added to the backlog as a direct result of user feedback or testing

Comments

@agrabeli
Copy link
Member

Problem

The Test List Editor was primarily designed for non-GitHub users, but once their contribution ends up as a pull request on GitHub, they are unlikely to interact with their pull request (which would require the creation of a GitHub account).

Most test list pull requests involve discussion between reviewers and contributors, where reviewers share feedback for changes, explain why they may not be willing to merge the specific pull request, or make other proposals. Based on this feedback, contributors often make changes to their pull requests before they are eventually merged. All of these discussions take place in the pull request comments, which Test List Editor users are unlikely to see or respond to, since they're not GitHub users.

As a result, there is the risk that pull requests may end up getting rejected without discussion, or without enabling contributors to make improvements so that their pull requests are merged. Ultimately, this may dis-encourage contributions, as contributors may be left confused about why their contributions are not integrated into the test lists.

Going forward

I this it's important that we explore ways to enable Test List Editor users to:

  • View comments/feedback by test list reviewers
  • Respond to reviewer comments/feedback without having to create GitHub accounts

This need was also highlighted by a community member on the OONI Slack channel today.

@agrabeli agrabeli added priority/medium enhancement improving existing code or new feature user feedback requests that have been added to the backlog as a direct result of user feedback or testing labels Jul 27, 2022
@hellais
Copy link
Member

hellais commented Nov 10, 2022

Currently the workaround is to click on the PR link and view the comments if they are there. We should also add some text telling people they can reach out to us via email in case they aren't github users.

Bumping down the priority since implementing the feature is a lot of work.

@hellais
Copy link
Member

hellais commented Nov 10, 2022

xref: #69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improving existing code or new feature icebox priority/low user feedback requests that have been added to the backlog as a direct result of user feedback or testing
Projects
Status: No status
Development

No branches or pull requests

4 participants