Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: release 3.19 #2524

Closed
24 of 26 tasks
bassosimone opened this issue Aug 23, 2023 · 3 comments
Closed
24 of 26 tasks

cli: release 3.19 #2524

bassosimone opened this issue Aug 23, 2023 · 3 comments
Assignees
@bassosimone
Labels
priority/medium releaseBlocker This issue blocks releasing

Comments

@bassosimone
Copy link
Contributor

bassosimone commented Aug 23, 2023 •
edited
Loading

@bassosimone bassosimone self-assigned this Aug 23, 2023
bassosimone added a commit to ooni/probe-cli that referenced this issue Aug 23, 2023
@bassosimone
chore: upgrade C dependencies
eb282bb 
Part of ooni/probe#2524. Prompted by observing
a failing Linux build test for zlib.

Upgrading to OpenSSL v3 is tracked by ooni/probe#2498
and implemented by #1191.

While there, fix ./pkg/oonimkall integration tests as well.
@bassosimone bassosimone mentioned this issue Aug 23, 2023
Merged
bassosimone added a commit to ooni/probe-cli that referenced this issue Aug 23, 2023
@bassosimone
chore: upgrade C dependencies (#1194)
2d8cde9 
Part of ooni/probe#2524. Prompted by observing
a failing Linux build test for zlib.

Upgrading to OpenSSL v3 is tracked by
ooni/probe#2498 and implemented by
#1191.

While there, fix ./pkg/oonimkall integration tests as well.
@jefferyto
Copy link

It would be great to have 3.19 released with support for Go 1.21.

@bassosimone
Copy link
Contributor Author

@jefferyto ACK, I will see of this is possible!

@bassosimone bassosimone added the releaseBlocker This issue blocks releasing label Oct 4, 2023
@bassosimone bassosimone mentioned this issue Oct 4, 2023
Closed
bassosimone added a commit to ooni/probe-cli that referenced this issue Oct 4, 2023
@bassosimone
chore: upgrade to Psiphon-Labs/psiphon-tunnel-core@3f91b1b
939b672 
See ooni/probe#2524
@bassosimone bassosimone mentioned this issue Oct 4, 2023
Merged
bassosimone added a commit to ooni/probe-cli that referenced this issue Oct 4, 2023
@bassosimone
chore: upgrade to Psiphon-Labs/psiphon-tunnel-core@3f91b1b (#1338)
24ce473 
See ooni/probe#2524
bassosimone added a commit to ooni/probe-cli that referenced this issue Oct 4, 2023
@bassosimone
chore: upgrade C dependencies
431120d 
Part of ooni/probe#2524
@bassosimone bassosimone mentioned this issue Oct 4, 2023
Merged
bassosimone added a commit to ooni/oohttp that referenced this issue Oct 4, 2023
@bassosimone
chore: prepare syncing with go1.20.8
926efc6 
See ooni/probe#2524
bassosimone added a commit to ooni/oohttp that referenced this issue Oct 4, 2023
@bassosimone
chore: update to go1.20.8 (#47)
dbb36a6 
Part of ooni/probe#2524
bassosimone added a commit to ooni/oohttp that referenced this issue Oct 4, 2023
@bassosimone
chore: update examples to use go1.20.8
d5bed05 
Part of ooni/probe#2524
@bassosimone bassosimone mentioned this issue Oct 4, 2023
Merged
bassosimone added a commit to ooni/oocrypto that referenced this issue Oct 4, 2023
@bassosimone
chore: update to go1.20.8 (#21)
2dfb6ff 
Part of ooni/probe#2524
bassosimone added a commit to ooni/probe-cli that referenced this issue Oct 4, 2023
@bassosimone
chore: use go1.20.8
50e74d2 
Part of ooni/probe#2524
@bassosimone bassosimone mentioned this issue Oct 4, 2023
Merged
bassosimone added a commit to ooni/historical-geoip that referenced this issue Oct 4, 2023
@bassosimone
chore: update go dependencies
bc122eb 
See ooni/probe#2524
@bassosimone bassosimone mentioned this issue Oct 4, 2023
Merged
bassosimone added a commit to ooni/historical-geoip that referenced this issue Oct 4, 2023
@bassosimone
chore: update go dependencies (#7)
45b3c9a 
See ooni/probe#2524
bassosimone added a commit to ooni/probe-cli that referenced this issue Oct 4, 2023
@bassosimone
chore: use go1.20.8 (#1340)
e69ba88 
Part of ooni/probe#2524
bassosimone added a commit to ooni/probe-assets that referenced this issue Oct 4, 2023
@bassosimone
chore: use 2023-10 database
8bc10a7 
See ooni/probe#2524
bassosimone added a commit to ooni/probe-cli that referenced this issue Oct 4, 2023
@bassosimone
chore: use 2023-10 geoip database
11ecd67 
Part of ooni/probe#2524
@bassosimone bassosimone mentioned this issue Oct 4, 2023
Merged
bassosimone added a commit to ooni/probe-cli that referenced this issue Oct 4, 2023
@bassosimone
chore: use 2023-10 geoip database (#1341)
9dedb7a 
Part of ooni/probe#2524
bassosimone added a commit to ooni/probe-cli that referenced this issue Oct 4, 2023
@bassosimone
chore: use gomajor to upgrade direct deps
7c3d519 
This diff uses the https://github.com/icholy/gomajor tool to
upgrade *direct* dependencies. More work is needed to take care
of indirect dependencies, snowflake, obfs4, etc.

Part of ooni/probe#2524
bassosimone added a commit to ooni/probe-cli that referenced this issue Oct 11, 2023
@bassosimone
[backport] chore(ooniprobe): add riseupvpn to experimental test suite
0eabe59 
This diff backports #1365 to the release/3.19 branch.

Concludes riseupvpn work for release 3.19.

Reference issue: ooni/probe#2524.
bassosimone added a commit to ooni/probe-cli that referenced this issue Oct 11, 2023
@bassosimone
chore: we're now hacking on v3.19.0-alpha.3
05e3716 
Part of ooni/probe#2524
@bassosimone bassosimone mentioned this issue Oct 12, 2023
Closed
bassosimone added a commit to ooni/probe-cli that referenced this issue Oct 12, 2023
@bassosimone
chore: we're now hacking on v3.19.0-alpha.4
53cad17 
Part of ooni/probe#2524
@bassosimone bassosimone mentioned this issue Oct 12, 2023
Closed
@aanorbel aanorbel mentioned this issue Oct 16, 2023
Merged
This was referenced Oct 17, 2023
Closed
Closed
Closed
Closed
Closed
@bassosimone
Copy link
Contributor Author

I forked off follow-up issues. We can now close this issue.

aanorbel added a commit to ooni/probe-ios that referenced this issue Oct 20, 2023
@aanorbel @bassosimone
chore: use probe-cli v3.19.0 (#534)
beeac1f 
Part of ooni/probe#2524

## Proposed Changes

  - Enable `echcheck` ooni/probe#2567.
  - Enable. `riseupvpn`.
  - Add support for appending errors

---------

Co-authored-by: Simone Basso <[email protected]>
aanorbel added a commit to ooni/probe-android that referenced this issue Oct 20, 2023
@aanorbel
chore: use probe-cli v3.19.0 (#622)
a9d8054 
Part of ooni/probe#2524

## Proposed Changes

  - Enable `echcheck` ooni/probe#2567.
  - Add support for appending errors
Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this issue Feb 13, 2024
@bassosimone @Murphy-OrangeMud
chore: upgrade C dependencies (ooni#1194)
58629f0 
Part of ooni/probe#2524. Prompted by observing
a failing Linux build test for zlib.

Upgrading to OpenSSL v3 is tracked by
ooni/probe#2498 and implemented by
ooni#1191.

While there, fix ./pkg/oonimkall integration tests as well.
Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this issue Feb 13, 2024
@bassosimone @Murphy-OrangeMud
chore: upgrade to Psiphon-Labs/psiphon-tunnel-core@3f91b1b (ooni#1338)
4acfedc 
See ooni/probe#2524
Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this issue Feb 13, 2024
@bassosimone @Murphy-OrangeMud
chore: use go1.20.8 (ooni#1340)
576d130 
Part of ooni/probe#2524
Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this issue Feb 13, 2024
@bassosimone @Murphy-OrangeMud
chore: use 2023-10 geoip database (ooni#1341)
be7b768 
Part of ooni/probe#2524
Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this issue Feb 13, 2024
@bassosimone @Murphy-OrangeMud
chore: use gomajor to update direct deps (ooni#1342)
a674c6a 
This diff uses the https://github.com/icholy/gomajor tool to update
*direct* dependencies. More work is needed to take care of indirect
dependencies, snowflake, obfs4, etc.

Part of ooni/probe#2524
Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this issue Feb 13, 2024
@bassosimone @Murphy-OrangeMud
chore: run go generate ./... (ooni#1343)
1fb2502 
The https://github.com/iancoleman/strcase library changed its default
behavior between v0.2.0 and v0.3.0 such that:

- before `DNS_NXDOMAIN_error` became `DNSNXDOMAINError`;

- now it becomes `DnsNxdomainError`.

In the grand scheme of things, perhaps, this change makes sense for the
library. However, as a user, what I see is a breaking change between two
minor versions (admittedly we're at v0.x).

Because I don't know what would happen next and I don't want any more
surprises, I am forking [email protected].

This work is part of ooni/probe#2524
Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this issue Feb 13, 2024
@bassosimone @Murphy-OrangeMud
chore: update the user agent we use (ooni#1344)
937f7e2 
While there, make sure there are no changes in STUN servers.

Part of ooni/probe#2524
Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this issue Feb 13, 2024
@bassosimone @Murphy-OrangeMud
chore: upgrade C dependencies (ooni#1339)
99b6d88 
This diff updates C dependencies to the latest version.

Part of ooni/probe#2524.
Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this issue Feb 13, 2024
@bassosimone @Murphy-OrangeMud
chore: upgrade the NDK version (ooni#1345)
a2d7a2f 
Part of ooni/probe#2524
Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this issue Feb 13, 2024
@bassosimone @Murphy-OrangeMud
chore: upgrade most deps except snowflake (ooni#1346)
406a11e 
This diff upgrades most deps except for snowflake and related
dependencies such as goptlib.

The following diff contains the packages I *did not* update:

```diff
diff --git a/go.mod b/go.mod
index 09b51d97..54eecd98 100644
--- a/go.mod
+++ b/go.mod
@@ -37,7 +37,7 @@ require (
 	github.com/rubenv/sql-migrate v1.5.2
 	github.com/schollz/progressbar/v3 v3.13.1
 	github.com/upper/db/v4 v4.6.0
-	gitlab.com/yawning/obfs4.git v0.0.0-20230519154740-645026c2ada4
+	gitlab.com/yawning/obfs4.git v0.0.0-20231005123604-19f5a37fe427
 	gitlab.com/yawning/utls.git v0.0.12-1
 	golang.org/x/crypto v0.13.0
 	golang.org/x/net v0.15.0
@@ -74,13 +74,14 @@ require (
 	github.com/spf13/pflag v1.0.5 // indirect
 	github.com/stretchr/testify v1.8.4 // indirect
 	github.com/xhit/go-str2duration/v2 v2.1.0 // indirect
+	gitlab.com/yawning/edwards25519-extra v0.0.0-20231005122941-2149dcafc266 // indirect
 	gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/goptlib v1.5.0 // indirect
 	go.uber.org/mock v0.3.0 // indirect
 	golang.org/x/exp v0.0.0-20230905200255-921286631fa9 // indirect
 	golang.org/x/exp/typeparams v0.0.0-20230522175609-2e198f4a06a1 // indirect
 	golang.org/x/time v0.3.0 // indirect
 	gopkg.in/yaml.v3 v3.0.1 // indirect
-	gvisor.dev/gvisor v0.0.0-20230603040744-5c9219dedd33 // indirect
+	gvisor.dev/gvisor v0.0.0-20231005075148-09be6cec5e98 // indirect
 )

 require (
@@ -89,7 +90,7 @@ require (
 	github.com/alecthomas/units v0.0.0-20211218093645-b94a6e3cc137 // indirect
 	github.com/armon/go-proxyproto v0.0.0-20210323213023-7e956b284f0a // indirect
 	github.com/beorn7/perks v1.0.1 // indirect
-	github.com/bifurcation/mint v0.0.0-20180306135233-198357931e61 // indirect
+	github.com/bifurcation/mint v0.0.0-20210616192047-fd18df995463 // indirect
 	github.com/cespare/xxhash/v2 v2.2.0 // indirect
 	github.com/cheekybits/genny v1.0.0 // indirect
 	github.com/cognusion/go-cache-lru v0.0.0-20170419142635-f73e2280ecea // indirect
@@ -132,7 +133,7 @@ require (
 	github.com/prometheus/common v0.44.0 // indirect
 	github.com/prometheus/procfs v0.12.0 // indirect
 	github.com/refraction-networking/gotapdance v1.7.4 // indirect
-	github.com/refraction-networking/utls v1.3.3 // indirect
+	github.com/refraction-networking/utls v1.5.3 // indirect
 	github.com/sergeyfrolov/bsbuffer v0.0.0-20180903213811-94e85abb8507 // indirect
 	github.com/sirupsen/logrus v1.9.3 // indirect
 	github.com/spf13/cobra v1.7.0
@@ -142,11 +143,11 @@ require (
 	github.com/templexxx/xorsimd v0.4.2 // indirect
 	github.com/tjfoc/gmsm v1.4.1 // indirect
 	github.com/wader/filtertransport v0.0.0-20200316221534-bdd9e61eee78 // indirect
-	github.com/xtaci/kcp-go/v5 v5.6.2 // indirect
+	github.com/xtaci/kcp-go/v5 v5.6.3 // indirect
 	github.com/xtaci/smux v1.5.24 // indirect
 	gitlab.com/yawning/bsaes.git v0.0.0-20190805113838-0a714cd429ec // indirect
 	gitlab.com/yawning/edwards25519-extra.git v0.0.0-20230925102617-375edaeb7d45 // indirect
-	golang.org/x/mod v0.12.0 // indirect
+	golang.org/x/mod v0.13.0 // indirect
 	golang.org/x/term v0.12.0 // indirect
 	golang.org/x/text v0.13.0 // indirect
 	golang.org/x/tools v0.13.0 // indirect
```

The following updates would break the build:

- gvisor because the default branch is not go.mod ready;

- kcp-go because v5.6.3 requires go1.21;

- obfs4 because it requires changing goptlib, which I'll do next;

- mint because Psiphon requires that version of mint.

This work is part of ooni/probe#2524
Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this issue Feb 13, 2024
@bassosimone @Murphy-OrangeMud
chore: update obfs4, goptlib, snowflake (ooni#1347)
89c7385 
This diff upgrades obfs4, goptlib, and snowflake. I tried to import
lyrebird instead of obfs4, but that did not work as intended. It seems
tags aren't compatible with the format expected by Go (vX.Y.Z) and I did
not want to pin to the latest commit. I will report this issue to
lyrebird developers later today.

While there, also upgrade x/net and x/exp.

This work is part of ooni/probe#2524.

Here's what we could not upgrade (based on the content of `go.mod` after
we committed this diff and ran `go get -u -v -d ./...`):

```diff
diff --git a/go.mod b/go.mod
index 67e0af02..18175d73 100644
--- a/go.mod
+++ b/go.mod
@@ -80,7 +80,7 @@ require (
 	golang.org/x/exp/typeparams v0.0.0-20230522175609-2e198f4a06a1 // indirect
 	golang.org/x/time v0.3.0 // indirect
 	gopkg.in/yaml.v3 v3.0.1 // indirect
-	gvisor.dev/gvisor v0.0.0-20230603040744-5c9219dedd33 // indirect
+	gvisor.dev/gvisor v0.0.0-20231006032704-15cc3fcbbd77 // indirect
 )

 require (
@@ -89,7 +89,7 @@ require (
 	github.com/alecthomas/units v0.0.0-20211218093645-b94a6e3cc137 // indirect
 	github.com/armon/go-proxyproto v0.0.0-20210323213023-7e956b284f0a // indirect
 	github.com/beorn7/perks v1.0.1 // indirect
-	github.com/bifurcation/mint v0.0.0-20180306135233-198357931e61 // indirect
+	github.com/bifurcation/mint v0.0.0-20210616192047-fd18df995463 // indirect
 	github.com/cespare/xxhash/v2 v2.2.0 // indirect
 	github.com/cheekybits/genny v1.0.0 // indirect
 	github.com/cognusion/go-cache-lru v0.0.0-20170419142635-f73e2280ecea // indirect
@@ -132,7 +132,7 @@ require (
 	github.com/prometheus/common v0.44.0 // indirect
 	github.com/prometheus/procfs v0.12.0 // indirect
 	github.com/refraction-networking/gotapdance v1.7.4 // indirect
-	github.com/refraction-networking/utls v1.3.3 // indirect
+	github.com/refraction-networking/utls v1.5.3 // indirect
 	github.com/sergeyfrolov/bsbuffer v0.0.0-20180903213811-94e85abb8507 // indirect
 	github.com/sirupsen/logrus v1.9.3 // indirect
 	github.com/spf13/cobra v1.7.0
@@ -142,10 +142,10 @@ require (
 	github.com/templexxx/xorsimd v0.4.2 // indirect
 	github.com/tjfoc/gmsm v1.4.1 // indirect
 	github.com/wader/filtertransport v0.0.0-20200316221534-bdd9e61eee78 // indirect
-	github.com/xtaci/kcp-go/v5 v5.6.2 // indirect
+	github.com/xtaci/kcp-go/v5 v5.6.3 // indirect
 	github.com/xtaci/smux v1.5.24 // indirect
 	gitlab.com/yawning/bsaes.git v0.0.0-20190805113838-0a714cd429ec // indirect
-	golang.org/x/mod v0.12.0 // indirect
+	golang.org/x/mod v0.13.0 // indirect
 	golang.org/x/term v0.13.0 // indirect
 	golang.org/x/text v0.13.0 // indirect
 	golang.org/x/tools v0.13.0 // indirect
```

We cannot upgrade:

- gvisor because (a) we're fine with our pinned version used by netem
and (b) the main branch of gvistor is not suitable for go-getting anyway

- mint because this is the version Psiphon requires

- utls because this is the version Psiphon requires

- kcp-go because v.5.6.3 requires go1.21

- x/mod which seems to be needed by quic-go to generate mocks, so not
upgrading it isn't a big deal.
Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this issue Feb 13, 2024
@bassosimone @Murphy-OrangeMud
chore: we're now hacking on v3.20.0-alpha (ooni#1356)
5d4435d 
Part of ooni/probe#2524
Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this issue Feb 13, 2024
@bassosimone @Murphy-OrangeMud
fix(torsf): bump the version number (ooni#1357)
f352783 
We changed the SNI, so let's change also the version number.

Part of ooni/probe#2524.
Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this issue Feb 13, 2024
@bassosimone @Murphy-OrangeMud
chore: use go1.20.10 (ooni#1362)
6069871 
Part of ooni/probe#2524
Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this issue Feb 13, 2024
@bassosimone @Murphy-OrangeMud
chore(ooniprobe): add riseupvpn to experimental test suite (ooni#1365)
736e5e6 
Concludes riseupvpn work for release 3.19.

Reference issue: ooni/probe#2524.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bassosimone bassosimone

Labels
priority/medium releaseBlocker This issue blocks releasing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jefferyto @bassosimone