chore: replace obfs4 with lyrebird #1348
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff replaces obfs4 and uses lyrebird instead. See #1347 (comment) to understand why my previous assessment that we could not import lyrebird was actually caused by PEBCAK. The build currently fails because the set of dependencies required by Psiphon conflict with lyrebird ones, so upgrading isn't possible. Here is how the build fails: ```console $ go build -v ./... github.com/Psiphon-Labs/psiphon-tunnel-core/psiphon/common/protocol /home/sbs/go/pkg/mod/github.com/!psiphon-!labs/[email protected]/psiphon/common/protocol/customTLSProfiles.go:180:16: undefined: utls.UtlsExtendedMasterSecretExtension ``` So, I think the underlying issue here may be that utls has removed some symbols without bumping their major version number. If it was possible to merge this work, this work would be part of the ooni/probe#2524 issue.
This was referenced Oct 6, 2023
|
This PR served to document why we cannot update to lyrebird right now. I'm going to close it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff replaces obfs4 and uses lyrebird instead. See #1347 (comment) to understand why my previous assessment that we could not import lyrebird was actually caused by PEBCAK.
The build currently fails because the set of dependencies required by Psiphon conflict with lyrebird ones, so upgrading isn't possible. Here is how the build fails:
So, I think the underlying issue here may be that utls has removed some symbols without bumping their major version number.
If it was possible to merge this work right now, it would have been part of the ooni/probe#2524 issue.