Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade C dependencies #1339

Merged
merged 2 commits into from
Oct 5, 2023
Merged

chore: upgrade C dependencies #1339

merged 2 commits into from
Oct 5, 2023

Conversation

bassosimone
Copy link
Contributor

@bassosimone bassosimone commented Oct 4, 2023

This diff updates C dependencies to the latest version.

I'm using androidbuild as the PR branch name such that we trigger an Android build.

Part of ooni/probe#2524.

@bassosimone bassosimone requested a review from hellais as a code owner October 4, 2023 11:26
@bassosimone bassosimone mentioned this pull request Oct 4, 2023
26 tasks
@bassosimone
Copy link
Contributor Author

I think it's worth mentioning I expect this PR to fail, since it the Android build has failed locally for me 😅

@bassosimone
Copy link
Contributor Author

Okay, now I am confused. How could this work on CI and not work locally?! Making the PR draft until I discover.

@bassosimone bassosimone marked this pull request as draft October 4, 2023 12:21
@bassosimone
Copy link
Contributor Author

Now it also works locally 🤷. What changed is that I ran make android as opposed to running individual commands going on memory. Perhaps, this is the reason why before it has failed. Marking this PR as ready again.

@bassosimone bassosimone marked this pull request as ready for review October 5, 2023 07:52
@bassosimone bassosimone merged commit 6636353 into master Oct 5, 2023
8 checks passed
@bassosimone bassosimone deleted the androidbuild branch October 5, 2023 08:39
Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this pull request Feb 13, 2024
This diff updates C dependencies to the latest version.

Part of ooni/probe#2524.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant